Prevent integrity constraint violation when order is canceled (#1473)

OpenMage · Feb 25, 2021 · 7f185e5 · 7f185e5
1 parent 741222f
commit 7f185e5
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/app/code/core/Mage/SalesRule/Model/Observer.php b/app/code/core/Mage/SalesRule/Model/Observer.php
@@ -159,7 +159,8 @@ public function sales_order_paymentCancel($observer)
                         Mage::getResourceModel('salesrule/coupon_usage')->updateCustomerCouponTimesUsed($customerId, $coupon->getId(), true);
 
                         // Decrement rule times_used
-                        if ($customerCoupon = Mage::getModel('salesrule/rule_customer')->loadByCustomerRule($customerId, $coupon->getRuleId())) {
+                        $customerCoupon = Mage::getModel('salesrule/rule_customer')->loadByCustomerRule($customerId, $coupon->getRuleId());
+                        if ($customerCoupon->getId()) {
                             $customerCoupon->setTimesUsed($customerCoupon->getTimesUsed() - 1);
                             $customerCoupon->save();
                         }