Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing start paragraph tag in password_or_email_changed.html email template #1401

Closed
addison74 opened this issue Jan 17, 2021 · 2 comments
Closed
Labels

Comments

@addison74
Copy link
Contributor

addison74 commented Jan 17, 2021

File: /app/locale/email/en_US/template/email/password_or_email_changed.html

Check line 27 there is a paragraph tag ending but without its start:

<table cellpadding="0" cellspacing="0" border="0">
    <tr>
        <td class="action-content">
            <h1>Hello {{htmlescape var=$customer.name}},</h1>
            {{if customer.is_change_password}}
            <p>We have received a request to change password associated with your account at {{var store.getFrontendName()}}.</p>
            {{/if}}
            {{if customer.is_change_email}}
            <br>We have received a request to change email associated with your account at {{var store.getFrontendName()}}.<br />
            <strong>Your new email is:</strong> {{var customer.email}}</p>
            {{/if}}
            <p>If you have not authorized this action, please contact us immediately {{depend store_phone}} at <a href="tel:{{var store_phone}}">{{var store_phone}}</a>{{/depend}}.</p>
        </td>
    </tr>

It should be a start paragraph tag <p> just before "We hare received a request [...]".

<table cellpadding="0" cellspacing="0" border="0">
    <tr>
        <td class="action-content">
            <h1>Hello {{htmlescape var=$customer.name}},</h1>
            {{if customer.is_change_password}}
            <p>We have received a request to change password associated with your account at {{var store.getFrontendName()}}.</p>
            {{/if}}
            {{if customer.is_change_email}}
            <br><p>We have received a request to change email associated with your account at {{var store.getFrontendName()}}.<br />
            <strong>Your new email is:</strong> {{var customer.email}}</p>
            {{/if}}
            <p>If you have not authorized this action, please contact us immediately {{depend store_phone}} at <a href="tel:{{var store_phone}}">{{var store_phone}}</a>{{/depend}}.</p>
        </td>
    </tr>
@addison74 addison74 added the bug label Jan 17, 2021
@dbachmann
Copy link
Contributor

Yes you're right. It's just a small bug but it should be correct. I fixed this with my last commit.

@sreichel
Copy link
Contributor

Yes you're right. It's just a small bug but it should be correct. I fixed this with my last commit.

Please open a PR to get this merged. :)

Flyingmana pushed a commit that referenced this issue Mar 10, 2021
… group by (#1404)

* [BUGFIX] Count doesn't work with group by columns. This fix keeps the group by.

* [BUGFIX] - Fixed html structural error in pnepage checkout payments section. When using definition term and definition description this items should be located in a definition list.

* [BUGFIX] - Fixed missing opening paragraph in email-template as mentioned in #1401

* [BUGFIX] Added fix to prevent sql injections as recommended by @colinmollenhour

* Added @dbachmann as contributor

* Revert "[BUGFIX] - Fixed missing opening paragraph in email-template as mentioned in #1401"

This reverts commit 3e66cf9.

* Revert "[BUGFIX] - Fixed html structural error in pnepage checkout payments section. When using definition term and definition description this items should be located in a definition list."

This reverts commit 345ab99.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants