[BUGFIX] Count doesn't work with group by columns. This fix keeps the group by

[dbachmann]

Some extensions like the Amasty Product Alerts Reports didn't worked correct because they use some group by statements in their queries. I've attached two screenshots.

Here is a stock alerts report before the fix

Here is a stock alert report after the fix

The second commit contains a fix for the onepage checkout. The base template used a fieldset as wrapper for payment methods in checkout. That is not correct because payment methods are defined as dt and dd.

[Flyingmana]

Thank you, looks like a good addition.
But we should check if this has somehow the potential for an SQL injection (iam not good enough into the DB Abstraction to know if reusing the group part is safe there)

[dbachmann]

The second commit contains a fix for the onepage checkout. The base template used a fieldset as wrapper for payment methods in checkout. That is not correct because payment methods are defined as dt and dd.

[colinmollenhour]

Good observation, @Flyingmana, the group part is usually quoted (in _renderGroup):

            $group = array();
            foreach ($this->_parts[self::GROUP] as $term) {
                $group[] = $this->_adapter->quoteIdentifier($term, true);
            }
            $sql .= ' ' . self::SQL_GROUP_BY . ' ' . implode(",\n\t", $group);

[dbachmann]

@colinmollenhour What would you suggest or what would you change?

[colinmollenhour]

Can you please remove the commits that are unrelated?

[dbachmann]

@colinmollenhour Done

[colinmollenhour]

Looks good!

[dbachmann]

@Flyingmana Could you take a look?

[github-actions]

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
2 runs  ±0  2 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit fd5796b. ± Comparison against base commit 62d9431.