Product qty is incremented when comment is added on a Credit Memo from SOAP API v2

[medgoprot]

Preconditions (*)

1. Should be reproducible on Open Mage.

Steps to reproduce (*)

1. Create a Credit Memo for any order either through the SOAP API v2 or the Admin panel
2. Add a comment on a Credit Memo via the SOAP API v2 and note the qty of the products in the inventory before and after

Expected result (*)

1. Adding a comment on the Credit Memo should not cause the refunded products' inventory qty to increment again

Actual result (*)

1. Adding a comment via the SOAP API causes the refunded products' inventory qty to be incremented again

After a long debugging session, it was found that the problem is arising from Mage_CatalogInventory_Model_Observer#refundOrderInventory which is observing the sales_order_creditmemo_save_after event that is dispatched after any save() of the Credit Memo, this is because in the event observer method (refundOrderInventory), there is no check to see whether the creditmemo object is new or not therefore it keeps adding the qty for all order items on every save.
Thanks

[fballiano]

I tested it but couldn't reproduce the error.

The qty is always 1, also if the last comment was added via SOAP.

[fballiano]

is salesOrderCreditmemoAddComment is method you call?

[medgoprot]

@fballiano Yes that's method being called. I think you misunderstood, I meant the inventory qty of the product and not the Creditmemo items' qty. I updated the description to make it more clear.

[fballiano]

the last comment on my screenshot was added via soap but the qty was kept at 1.

[fballiano]

another order, with ordered_qty = 10, refunded_qty = 1, created some comments via soap:

i'm on OM 20.0.10 tho

the soap call:

[medgoprot]

@fballiano Yes but I'm not talking about the refunded qty in the creditmemo, can you note the qty of the product in the inventory before vs. after adding the comment and see if it changes?

[medgoprot]

I'm talking about this qty, it gets incremented each time after adding a comment from the SOAP API

[fballiano]

so it's not the refunded_qty but the qty that goes back to stock?

[fballiano]

do you have this?

[fballiano]

oki, understood and reproduced

[fballiano]

I just submitted PR #1575 which solves the problem on my local installation.