Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product qty is incremented when comment is added on a Credit Memo from SOAP API v2 #1575

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

fballiano
Copy link
Contributor

Adding a comment to a creditmemo keeps "restocking" the products to the inventory, as explained in issue #1517

$creditmemo->getCommentsCollection()->save() is used in Mage_Adminhtml_Sales_Order_CreditmemoController::addCommentAction() and works correctly because it doesn't trigger a "save" on the creditmemo, but only on the comments.

Fixed Issues

  1. Fixes Product qty is incremented when comment is added on a Credit Memo from SOAP API v2 #1517

Adding a comment to a creditmemo keeps "restocking" the products to the inventory, as explained in issue #1517

$creditmemo->getCommentsCollection()->save() is used in Mage_Adminhtml_Sales_Order_CreditmemoController::addCommentAction() and works correctly because it doesn't trigger a "save" on the creditmemo, but only on the comments.
Copy link
Contributor

@kiatng kiatng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Flyingmana Flyingmana merged commit d72a57a into OpenMage:1.9.4.x Apr 30, 2021
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
6 runs  +4  4 ✔️ +2  0 💤 ±0  2 ❌ +2 

Results for commit d72a57a. ± Comparison against base commit f71321b.

@fballiano fballiano deleted the patch-4 branch May 28, 2021 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Sales Relates to Mage_Sales
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Product qty is incremented when comment is added on a Credit Memo from SOAP API v2
6 participants