-
-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stop /error/report.php from processing empty reports #1581
Comments
This should improve #1581 If checks that parameter $_GET['id'] is passed (it's then casted to int by processor.php) but ONLY if the report.php script is called directly. This first part of the check is necessary because report.php is included in Mage::printException()
@ulbiopro my PR was merged, can you please close the issue? |
@fballiano - My opinion that if such requests are not answered they should be closed by those who manage the project after a week. There are a lot of hangers who have no feedback from those who have them initially and we must strive for a reduction in the number for visibility and obviously for trust. When we see a limited number of issues we have a feeling that things are still moving forward. |
I totally agree but that doesn't happen, that's why I try tagging the original author |
Sorry for the late response. I had an longer ongoing vacation. |
This should improve OpenMage/magento-lts#1581 If checks that parameter $_GET['id'] is passed (it's then casted to int by processor.php) but ONLY if the report.php script is called directly. This first part of the check is necessary because report.php is included in Mage::printException()
A simple GET request on {BASE_URL}/errors/report.php will trigger processor.php to process an empty report. In case you set up an email report action, you get notified with empty "Store Debug Information" E-Mails.
Description (*)
Turn off the notification for empty messages. Or even better, if possible, deny webaccess on
report.php
andprocessor.php
.Benefits
Less junk? ;-)
Additional information
My question would be following:
Is it possible to suppress empty messages or could this cause trouble?
Like:
magento-lts/errors/processor.php
Lines 558 to 559 in cc3eff3
The text was updated successfully, but these errors were encountered: