Update report.php #1588
Merged
Update report.php #1588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix #1581 If checks that parameter $_GET['id'] is passed (it's then casted to int by processor.php) but ONLY if the report.php script is called directly. This first part of the check is necessary because report.php is included in Mage::printException()
kkrieger85
approved these changes
May 12, 2021
Flyingmana
approved these changes
May 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should improve #1581
If checks that parameter $_GET['id'] is passed (it's then casted to int by processor.php) but ONLY if the report.php script is called directly.
This first part of the check is necessary because report.php is included in Mage::printException()
I know that a "die" is maybe not the best option but... in the contest of this specific script, I think it's the only way.