Remove "compiler" related code

[Flyingmana]

For Years the Magento1 Compiler code is mostly unused and recommended against to use it.
To reduce Code/Logic (and because someone suggested it) I would like to see the Compiler related code be removed (maybe leave empty methods, in case its needed for compatibility reasons?)

What are your takes on this?

Context what it is:
https://magento.stackexchange.com/questions/179093/what-is-compilation-in-magento-and-its-use
and prove I have prejudice here:
https://magento.stackexchange.com/questions/12996/when-should-i-use-the-magento-compiler/15204#15204

[rafaelpatro]

Referring Alan Storm article 2011:
"In computer science the term compiler usually refers to transforming code from one language (like C) into another language (like binary machine code). The Magento compiler transforms PHP code into – more PHP code!"

I think since 2011 PHP performance was so increased that searching for M1 files in separate directories is no more a bottleneck. I don't remember where to find the reference but some time ago I've read a benchmark showing that M1 compiler has no effect in PHP7.

[Flyingmana]

a big part of this improvement is because of the OpCache, which additionally caches file access so effectively, that the number of files became not relevant for PHP anymore

[colinmollenhour]

+1, remove it to prevent use

[tmotyl]

just for a reference, long time ago together with Fabrizio we've developed an extension which caches autoloaded paths, as an alternative for the compiles https://github.com/AOEpeople/Aoe_ClassPathCache
Basically it remembering paths for all requested files, and then on destruct of varien autoload, it saved it to a file.

[FredericMartinez]

+1

[Ig0r-M-magic42]

👍