removed Mage_Compiler

[dng-dev]

Removed Mage_Compiler #525

[LeeSaferite]

Does it make sense to fix the autoloader at the same time?

It should be returning a false if the class isn't found. That would allow people to easily use composer autoloader in conjunction.

[dng-dev]

Will look over this later and implement it. Am Freitag, 21. September 2018 schrieb Lee Saferite :

…

Does it make sense to fix the autoloader at the same time? It should be returning a false if the class isn't found. That would allow people to easily use composer autoloader in conjunction. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#534 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAzB7_PHVxk-P8fpQ2yRjR2GELiWmJruks5udQxTgaJpZM4W0JmY> .

[dng-dev]

@seansan as mentioned i added the missing return statement for the autoloader.

[colinmollenhour]

Should Varien_Autoload::registerScope method be kept (doesn't need to do anything) just for BC?

[colinmollenhour]

Also any reason not to go ahead and replace __autoload with spl_autoload_register since the former is deprecated in PHP 7.2?

[Flyingmana]

the __autoload function can get deleted completely. Since the Varien Autoloader uses the SPL autoloader, this one is never in use.

[Flyingmana]

the BC break is I think acceptable.
usage is very low (or hard to find via github) and it fails early, so its fast to notice and easy to fix.
also, when keeping we would maybe also need to keep the other scope related functions...

I suggest to wait in this case, if there is really someone who is using this extensively.

Fixing the autoload function is easy done over a separate PR then afterwards