Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix call_user_func_array arguments for PHP 8 #1247

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Fix call_user_func_array arguments for PHP 8 #1247

merged 1 commit into from
Oct 20, 2020

Conversation

luigifab
Copy link
Contributor

@luigifab luigifab commented Oct 3, 2020 •
edited
Loading

Description

Changes second argument of call_user_func_array() from associative to indexed array. Before PHP 8 both types of arrays work the same but on PHP 8 associative arrays are interpreted as "named parameters". In our case this causes code to break.

OpenMage 20.0.3 / PHP 8.0.0-beta3
From joomla/joomla-cms#30608.

Manual testing scenarios

  1. Install PHP 8.0.0
  2. Open any page of OpenMage in your browser

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@github-actions github-actions bot added the Component: Core Relates to Mage_Core label Oct 3, 2020
colinmollenhour
colinmollenhour approved these changes Oct 5, 2020
View reviewed changes
Copy link
Member

@colinmollenhour colinmollenhour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@colinmollenhour colinmollenhour added the PHP 8 Related to PHP8 label Oct 5, 2020
@luigifab luigifab changed the title Fix call_user_func_array() arguments on PHP 8 Fix call_user_func_array arguments for PHP 8 Oct 10, 2020
@Flyingmana Flyingmana merged commit 731d961 into OpenMage:1.9.4.x Oct 20, 2020
@sreichel sreichel added this to the Release 19.4.8 / 20.0.4 milestone Oct 21, 2020
@kkrieger85 kkrieger85 added hacktoberfest easy to solve issues for https://hacktoberfest.digitalocean.com/ participant (and everyone else) hacktoberfest-accepted labels Oct 28, 2020
@luigifab luigifab deleted the php8 branch January 1, 2021 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flyingmana Flyingmana Flyingmana approved these changes

@colinmollenhour colinmollenhour colinmollenhour approved these changes

Assignees
No one assigned
Labels
Component: Core Relates to Mage_Core hacktoberfest easy to solve issues for https://hacktoberfest.digitalocean.com/ participant (and everyone else) hacktoberfest-accepted PHP 8 Related to PHP8
Projects
None yet
Milestone
Release 19.4.8 / 20.0.4
Development

Successfully merging this pull request may close these issues.
5 participants
@luigifab @colinmollenhour @Flyingmana @kkrieger85 @sreichel