Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove latest occurrences of XmlConnect #1383

Merged
merged 1 commit into from
Jan 29, 2021
Merged

Remove latest occurrences of XmlConnect #1383

merged 1 commit into from
Jan 29, 2021

Conversation

luigifab
Copy link
Contributor

@luigifab luigifab commented Jan 9, 2021

I searched in all files XmlConnect, and removed the CSV and a comment.

@github-actions github-actions bot added Component: Reports Relates to Mage_Reports translations Relates to app/locale labels Jan 9, 2021
@sreichel sreichel added Cleanup Cleanup: DOC blocks Related to DOC block updates and fixes. and removed Cleanup labels Jan 10, 2021
@sreichel sreichel linked an issue Jan 10, 2021 that may be closed by this pull request
Orphan images related to XML Connect #1296
Closed
@sreichel sreichel mentioned this pull request Jan 10, 2021
Closed
@jouriy
Copy link
Contributor

jouriy commented Jan 27, 2021 •
edited
Loading

As all occurrences of XmlConnect are removed, may be we should delete also the following files from the same package?

js/jscolor/*

@sreichel sreichel added this to the Release 19.4.11 / 20.0.7 milestone Jan 29, 2021
@sreichel sreichel merged commit 705389d into OpenMage:1.9.4.x Jan 29, 2021
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
2 runs  ±0  2 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 705389d. ± Comparison against base commit 1c6ca94.

@sreichel
Copy link
Contributor

As all occurrences of XmlConnect are removed, may be we should delete also the following files from the same package?

js/jscolor/*

Can you please open a PR?

jouriy added a commit to jouriy/magento-lts that referenced this pull request Jan 30, 2021
@jouriy
ref OpenMage#1383, cleanup - remove orphan js/jscolor/* from XmlConne…
0a77acf 
…ct package
@jouriy jouriy mentioned this pull request Jan 30, 2021
Merged
3 tasks
@luigifab luigifab deleted the remove-xmlconnect branch January 30, 2021 10:52
sreichel pushed a commit that referenced this pull request Feb 21, 2021
@jouriy
ref #1383, cleanup - remove orphan js/jscolor/* from XmlConnect packa…
e4c2c4c 
…ge (#1436)
@luigifab luigifab restored the remove-xmlconnect branch April 6, 2021 15:44
@luigifab luigifab deleted the remove-xmlconnect branch April 6, 2021 15:45
Flyingmana added a commit to Flyingmana/magento-lts that referenced this pull request May 15, 2021
@Flyingmana
Revert "ref OpenMage#1383, cleanup - remove orphan js/jscolor/* from …
21d67a5 
…XmlConnect package (OpenMage#1436)"

Fixes OpenMage#1615
This reverts commit e4c2c4c
@Flyingmana Flyingmana mentioned this pull request May 15, 2021
Merged
Flyingmana added a commit that referenced this pull request May 17, 2021
@Flyingmana
Revert "ref #1383, cleanup - remove orphan js/jscolor/* from XmlConne…
9b04ad2 
…ct package (#1436)" (#1616)

Fixes #1615
This reverts commit e4c2c4c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sreichel sreichel sreichel approved these changes

@colinmollenhour colinmollenhour colinmollenhour approved these changes

@tmotyl tmotyl Awaiting requested review from tmotyl

Assignees
No one assigned
Labels
Cleanup: DOC blocks Related to DOC block updates and fixes. Component: Reports Relates to Mage_Reports translations Relates to app/locale
Projects
None yet
Milestone
Release 19.4.11 / 20.0.7
Development

Successfully merging this pull request may close these issues.

Orphan images related to XML Connect
4 participants
@luigifab @jouriy @sreichel @colinmollenhour