Revert "cleanup - remove orphan js/jscolor/* from XmlConnect package (#1436)" #1616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…XmlConnect package (OpenMage#1436)" Fixes OpenMage#1615 This reverts commit e4c2c4c
Flyingmana
changed the title
|
Thank you @Flyingmana for your quick reaction. Do we need the demo.html file in this directory? |
|
probably not needed, but just reverting was the fastest |
colinmollenhour
approved these changes
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert "ref #1383, cleanup - remove orphan js/jscolor/* from XmlConnect package (#1436)
reverting, as jscolor is used by 3th party modules, so removing it is a big BC breaks.
Reverts #1436
Fixes #1615
This reverts commit e4c2c4c