-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed module Mage_PageCache #2258
Conversation
This module is related to "External Full Page Cache Settings" section in Backend. Even you Enable the module it works only if there is an external cache. See the image bellow: The only "External Cache Control" option available is "Zend Full Page Cache". Then you are able to flush the external page cache from "Cache Storage Management" page: How many use Zend server? I never use it and I consider it far inferior to the Varnish-based Turpentine extension. If anyone is using it please let us know. If there is no feedback in 2 weeks I will approve it on my behalf. |
You have to mention the removal of this module from OpenMage in the README.md file. There is a section named "Removed Modules". |
done |
From what I notice we have no opinions to keep this module in OpenMage. Therefore I don't have to wait two weeks to approve the PR. I clicked the button. There is a conflict related to an XML that must be resolved. |
fixed the conflict and a typo ;-) |
would need to check, but I think a php based fullPage cache I build 7y ago could have used this as base. but guess removing it ks ok, if no modern module uses parts of it. |
I'd just suggest to use Lesti :-) |
mine might have been less flexible, but I got constantly ~40-60ms response times on cached pages. Is it comparable in performance? |
No they're much higher (at least on the production website I'm using it in) but it's probably because of the holepunching dynamic blocks |
fixed phpstan |
fixed conflict in README |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, this page cache when I reviewed it appeared to be almost unusable.
The Mage_PageCache was a half baked first attempt at pagecache for community edition.
As far as I can see it lacks basic features like holepunching and support for modern technologies like redis.
It only supports Zend_Server which probably doesn't even exist anymore.
PS: I also found out that, just having it enabled, broke my varnish/turpentine.