-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed Mage_PageCache #2813
Merged
Merged
Removed Mage_PageCache #2813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: Adminhtml
Relates to Mage_Adminhtml
Component: PageCache
Relates to Mage_PageCache
documentation
phpstan
PHPStorm
Template : admin
Relates to admin template
translations
Relates to app/locale
labels
Dec 16, 2022
if we backport everything we should just merge v20 in v19 and call it a day ;-) |
That would be to easy 😆 |
that is what i mean when i say to drop v19 in favour of v20 |
I've created https://github.com/OpenMage/module-mage-pagecache for you ;-) |
Pushed. |
fballiano
previously approved these changes
Dec 18, 2022
about adding it to the release builder, I wouldn't do that (my personal opinion) for these reason:
|
fballiano
approved these changes
Dec 23, 2022
addison74
approved these changes
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Adminhtml
Relates to Mage_Adminhtml
Component: PageCache
Relates to Mage_PageCache
documentation
PHPStorm
Template : admin
Relates to admin template
Template : base
Relates to base template
translations
Relates to app/locale
XML Layout
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Mage_PageCache
was removed for v20 only. Created composer module to keep functionality if needed.Related Pull Requests
Can be reinstalled with
composer require openmage/module-mage-pagecache:dev-master
Questions or comments
@fballiano should we add these modules to releasebuilder?
Contribution checklist (*)