Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable module Mage_Backup #2782

Closed
wants to merge 1 commit into from
Closed

Enable module Mage_Backup #2782

wants to merge 1 commit into from

Conversation

eneiasramos
Copy link
Contributor

@eneiasramos eneiasramos commented Dec 4, 2022

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes OpenMage/magento-lts#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@sreichel
Copy link
Contributor

sreichel commented Dec 4, 2022

Why? Mage_Backup has been disabled for some reasons and is only kept for users, that really want to use it. (See #2259)

@sreichel sreichel added the Component: Backup Relates to Mage_Backup label Dec 4, 2022
@eneiasramos
Copy link
Contributor Author

@sreichel A lot of people still use this functionality.

@fballiano
Copy link
Contributor

Totally against and already discussed

@sreichel
Copy link
Contributor

sreichel commented Dec 4, 2022

@sreichel A lot of people still use this functionality.

I know. I was against to delete it completly, but its recommended to not use it and i also dont want to have it enabled per default.

@sreichel sreichel closed this Dec 4, 2022
@addison74
Copy link
Contributor

We discussed about this module here #2024 and I presented the reasons why the Magento team disabled it in the past.

Here a PR was created to remove the module which was closed after discussions #2259.

As long as it is deactivated it could not create trouble for anyone. Whoever wants to use the module can activate it knowing that they may expose themselves to certain risks, especially those related to data protection. However, the Magento team's message was lacking in details, just a statement and that's it. Rather, the issues in this module, which are still unfixed there, would worry me more, as at first glance it does its job according to the user manual.

Although I never used it (but I did intensive tests to find out issues), I was for its preservation considering an average user who prefers this solution instead of some exports from the database (from a UI, from the command line). I also considered that some functional extensions could use classes from this module to implement various tasks.

In conclusion, I agree with the closure of this PR for the stated reasons.

@sreichel sreichel mentioned this pull request Dec 16, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Backup Relates to Mage_Backup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants