Removed Mage_Backup #2811

sreichel · 2022-12-16T03:14:54Z

Description (*)

Removed Mage_Backup code.

Can be reinstalled with composer require openmage/module-mage-backup

Related Pull Requests

Questions or comments

Repo should be moved to OM space.

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All automated tests passed successfully (all builds are green)
Add yourself to contributors list

fballiano · 2022-12-16T10:24:53Z

but what about my pr? 🥺🥺

fballiano · 2022-12-16T10:26:24Z

but what about my pr? 🥺🥺

ah right, it was broken.

well, as everybody knows I'm all for this.

addison74 · 2022-12-17T10:51:31Z

Here #2024 and here #2259 we discussed this module. @fballiano said that there are big issues in the code of this module that the Magento team no longer wanted to solve, other than the data security ones shown by me.

I personally agree with removing it and installing it from a repository by anyone who is interested. I would go a little further, if we remove the code no one can create PRs from now on. Wouldn't it be better to create a new OpenMage repository here on GitHub so that any contribution can be made and we know about it? Those who are interested can install it either with Composer or put it back by downloading the archive and copying the files in OpenMage installation.

fballiano · 2022-12-17T10:54:41Z

the repo, at the moment, is https://github.com/sreichel/openmage-module-mage-backup :-)

addison74 · 2022-12-17T11:08:02Z

I know but we should have it as a branch in OpenMage.

sreichel · 2022-12-17T18:59:18Z

@addison74 aggreed, but i cant add repos to OpenMage space.

# Conflicts: # app/code/core/Mage/Adminhtml/Block/Backup/Grid.php

fballiano · 2022-12-18T07:23:02Z

I've created https://github.com/OpenMage/module-mage-backup for you

sreichel · 2022-12-18T07:43:50Z

Why i cant do this?

Seems i cannot push.

fballiano · 2022-12-18T16:55:03Z

I don't know why you can't do that but anyway I've invite you as maintainer for that repo, but it seems the invite was accepted yes

sreichel · 2022-12-18T19:18:51Z

Thanks. Its there.

fballiano · 2022-12-18T19:24:45Z

did you change the packagist references too? can you? (I cannot)

sreichel · 2022-12-18T19:28:32Z

yes. moved both

fballiano · 2022-12-18T19:56:41Z

Before approving it, I would like to ask you what happens with Tools branch in the Backend > System menu. The "Backups" and "Compilation" links have been grouped here. The latter has been removed from OpenMage for some time, the former via this PR. Under these conditions, System > Tools should no longer exist in OpenMage and it can be removed, I guess through another PR.

I think it would disappear but it wouldn't be a problem because it reappears automatically in case a module (that uses it) gets installed

sreichel · 2022-12-18T20:08:21Z

@addison74 "tools" should not be visible when Mage_Backup is disabled (default). If you enable it "tools" appears.

Flyingmana

Replacement module should have at least one valid Release, just in case we need to do a bugfix or bc breaking release.
Version 1.0.0 would be alright.

PS: I cant do this myself as I did not get permissions assigned for the related repository

README.md

Updated README

addison74 · 2022-12-25T20:17:55Z

With the default installation there are 3 modules having the output disabled Mage_Backup, Mage_Poll, Mage_Tag. Sven is right when the Mage_Backup module is disabled from XML configuration or its output in Backend the Tools link doesn't appear in System menu.

If you have made sure that you have identified all the files of this module I don't see what would prevent us from approving it.

sreichel · 2022-12-25T23:12:33Z

With the default installation there are 3 modules having the output disabled Mage_Backup, Mage_Poll, Mage_Tag.

@Flyingmana @fballiano can you please create repos for Mage_Poll and Mage_Tag or give permission? 😎

fballiano · 2022-12-25T23:51:21Z

I can't give you that permission but I made you admin for https://github.com/OpenMage/module-mage-poll and https://github.com/OpenMage/module-mage-tag

# Conflicts: # .gitignore # app/code/core/Mage/Backup/Helper/Data.php # app/code/core/Mage/Backup/Model/Backup.php # app/code/core/Mage/Backup/etc/adminhtml.xml # app/code/core/Mage/Backup/etc/config.xml # lib/Mage/Backup.php # lib/Mage/Backup/Archive/Tar.php # lib/Mage/Backup/Db.php # lib/Mage/Backup/Exception.php # lib/Mage/Backup/Exception/CantLoadSnapshot.php # lib/Mage/Backup/Exception/FtpConnectionFailed.php # lib/Mage/Backup/Exception/FtpValidationFailed.php # lib/Mage/Backup/Exception/NotEnoughFreeSpace.php # lib/Mage/Backup/Exception/NotEnoughPermissions.php # lib/Mage/Backup/Filesystem.php # lib/Mage/Backup/Filesystem/Helper.php # lib/Mage/Backup/Filesystem/Rollback/Abstract.php # lib/Mage/Backup/Filesystem/Rollback/Fs.php # lib/Mage/Backup/Filesystem/Rollback/Ftp.php # lib/Mage/Backup/Interface.php # lib/Mage/Backup/Media.php # lib/Mage/Backup/Nomedia.php # lib/Mage/Backup/Snapshot.php

sreichel · 2023-01-02T00:09:32Z

Yeah ... conflicts on a file to delete ... :/

# Conflicts: # app/code/core/Mage/Backup/Model/Config/Backend/Cron.php

fballiano

I don't understand how this is not considered BC while #2863 is, but they're both ok in my opinion

sreichel · 2023-01-03T22:11:22Z

Dont think its a breaking change. It should be included in download and everyone who uses composer can install it when required. Just needs some documentation.

fballiano · 2023-01-03T22:14:21Z

you know what I was referring to

sreichel added 2 commits December 16, 2022 02:07

Fixes

b40a891

Removed Mage_Backup

96448ed

Update phpstorm.meta

42a4ee2

github-actions bot added the PHPStorm label Dec 16, 2022

fballiano previously approved these changes Dec 16, 2022

View reviewed changes

Removed translations

6cfecee

sreichel dismissed fballiano’s stale review via 6cfecee December 16, 2022 19:05

github-actions bot added the translations Relates to app/locale label Dec 16, 2022

Merge branch '1.9.4.x' into phpstan/mage-backup

43ea148

# Conflicts: # app/code/core/Mage/Adminhtml/Block/Backup/Grid.php

fballiano previously approved these changes Dec 18, 2022

View reviewed changes

Flyingmana previously requested changes Dec 24, 2022

View reviewed changes

README.md Outdated Show resolved Hide resolved

sreichel dismissed fballiano’s stale review via 367ac4f December 25, 2022 01:55

fballiano previously approved these changes Dec 25, 2022

View reviewed changes

phpstan.dist.baseline.neon fix

07d33e4

sreichel dismissed fballiano’s stale review via 07d33e4 December 25, 2022 02:44

Merge branch '1.9.4.x' into phpstan/mage-backup

5383f8e

sreichel added 2 commits December 26, 2022 07:09

Merge branch '1.9.4.x' into phpstan/mage-backup

667dd5c

luigifab previously approved these changes Jan 1, 2023

View reviewed changes

fballiano previously approved these changes Jan 1, 2023

View reviewed changes

Merge branch '1.9.4.x' into phpstan/mage-backup

3c278e3

# Conflicts: # app/code/core/Mage/Backup/Model/Config/Backend/Cron.php

sreichel dismissed stale reviews from fballiano and luigifab via 3c278e3 January 2, 2023 00:11

addison74 approved these changes Jan 2, 2023

View reviewed changes

fballiano mentioned this pull request Jan 3, 2023

Backported #1600: removed M1 legacy themes #2863

Merged

fballiano approved these changes Jan 3, 2023

View reviewed changes

fballiano merged commit 1fd35a1 into OpenMage:1.9.4.x Jan 3, 2023

sreichel deleted the phpstan/mage-backup branch January 3, 2023 22:11

fballiano pushed a commit that referenced this pull request Jan 3, 2023

Removed Mage_Backup (#2811)

ba7f510

fballiano mentioned this pull request Jan 3, 2023

Require Mage_Backup and Mage_PageCache on v19's release builder #2890

Merged

Flyingmana added the backwards compatibility Might affect backwards compatibility for some users label Jan 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removed Mage_Backup #2811

Removed Mage_Backup #2811

sreichel commented Dec 16, 2022 •

edited

Loading

fballiano commented Dec 16, 2022

fballiano commented Dec 16, 2022

addison74 commented Dec 17, 2022

fballiano commented Dec 17, 2022

addison74 commented Dec 17, 2022

sreichel commented Dec 17, 2022

fballiano commented Dec 18, 2022

sreichel commented Dec 18, 2022

fballiano commented Dec 18, 2022

sreichel commented Dec 18, 2022

fballiano commented Dec 18, 2022

sreichel commented Dec 18, 2022

fballiano commented Dec 18, 2022

sreichel commented Dec 18, 2022

Flyingmana left a comment

addison74 commented Dec 25, 2022

sreichel commented Dec 25, 2022

fballiano commented Dec 25, 2022

sreichel commented Jan 2, 2023

fballiano left a comment

sreichel commented Jan 3, 2023

fballiano commented Jan 3, 2023

Removed Mage_Backup #2811

Removed Mage_Backup #2811

Conversation

sreichel commented Dec 16, 2022 • edited Loading

Description (*)

Related Pull Requests

Questions or comments

Contribution checklist (*)

fballiano commented Dec 16, 2022

fballiano commented Dec 16, 2022

addison74 commented Dec 17, 2022

fballiano commented Dec 17, 2022

addison74 commented Dec 17, 2022

sreichel commented Dec 17, 2022

fballiano commented Dec 18, 2022

sreichel commented Dec 18, 2022

fballiano commented Dec 18, 2022

sreichel commented Dec 18, 2022

fballiano commented Dec 18, 2022

sreichel commented Dec 18, 2022

fballiano commented Dec 18, 2022

sreichel commented Dec 18, 2022

Flyingmana left a comment

Choose a reason for hiding this comment

addison74 commented Dec 25, 2022

sreichel commented Dec 25, 2022

fballiano commented Dec 25, 2022

sreichel commented Jan 2, 2023

fballiano left a comment

Choose a reason for hiding this comment

sreichel commented Jan 3, 2023

fballiano commented Jan 3, 2023

sreichel commented Dec 16, 2022 •

edited

Loading