Do not reindex catalog_product_flat for disabled stores

[empiricompany]

Description (*)

skip reindex product flat tables for disabled store view

Questions or comments

We have one store with 6 language stores, of which only one is enabled. The reindexing of the product flat tables takes unnecessarily long. The idea is to skip the reindexing of disabled stores. I don't think this will create any problems because these tables are not actually used on the frontend. Are there any potential issues with this approach?

We should add a message indicating that a reindex is required when the store is re-enabled, similar to what happens with the index catalog_product_attribute.

[fballiano]

wow, this could be a great improvement, how did it slip for so many years...

sorry for reformatting the "continue", I also prefer the one line but PHPCS doesn't :-(

[sreichel]

Message after enable store needs to be added.

[empiricompany]

Message after enable store needs to be added.

I'm not an indexer expert, but now the reindex request message also appears for catalog_product_flat.
The code that checks if it's a save and was previously disabled was taken from the EAV index (app/code/core/Mage/Catalog/Model/Product/Indexer/Eav.php).
I'm just wondering if anything else needs to be added in _registerEvent.

[kyrena]

Full reindex: from 02:37 (before) to 01:23 (after).

Notice is displayed after enabling a store view.
I dropped catalog_flat tables and I reindexed multiple times, all seems good for front.

This probably also can be done for catalog_category_flat.
Moreover there are multiple Mage::app()->getStores().

[fballiano]

merging per 1green and 2grays