Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not reindex catalog_product_flat for disabled stores #3251

Merged
merged 10 commits into from
Jul 12, 2023
Merged

Do not reindex catalog_product_flat for disabled stores #3251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
189a582
do not reindex disabled stores
empiricompany May 14, 2023
ffe2ab5
phpcs
fballiano May 14, 2023
ebd661f
Merge branch 'main' into main
fballiano May 14, 2023
22f00e5
PHPCS complains
empiricompany May 14, 2023
4d13d28
add notice index rebuild message after enabled store
empiricompany May 16, 2023
d9819d0
Merge branch 'main' of https://github.com/empiricompany/magento-lts i…
empiricompany May 16, 2023
29e531a
clean
empiricompany May 16, 2023
8a6f941
Merge branch 'main' into main
fballiano May 25, 2023
bdba659
Merge branch 'OpenMage:main' into main
empiricompany Jun 6, 2023
c124a27
Merge branch 'main' into main
fballiano Jul 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/code/core/Mage/Catalog/Model/Product/Indexer/Flat.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ public function matchEvent(Mage_Index_Model_Event $event)
} else {
/** @var Mage_Core_Model_Store $store */
$store = $event->getDataObject();
if ($store && $store->isObjectNew()) {
if ($store && ($store->isObjectNew() || $store->getOrigData('is_active') != $store->getIsActive() && $store->getIsActive())) {
fballiano marked this conversation as resolved.
Show resolved Hide resolved
$result = true;
} else {
$result = false;
Expand Down
3 changes: 3 additions & 0 deletions app/code/core/Mage/Catalog/Model/Resource/Product/Flat/Indexer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1400,6 +1400,9 @@ protected function _arrayNextKey(array $array, $key)
public function reindexAll()
{
foreach (Mage::app()->getStores() as $storeId => $store) {
if (!$store->getIsActive()) {
continue;
}
$this->prepareFlatTable($storeId);
$this->beginTransaction();
try {
Expand Down