Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mypy to tests #251

Closed
chinmayshah99 opened this issue Aug 16, 2020 · 0 comments · Fixed by #308
Closed

Add mypy to tests #251

chinmayshah99 opened this issue Aug 16, 2020 · 0 comments · Fixed by #308
Labels
Hacktoberfest Open for hacktoberfest 2020 Type: New Feature ➕ Introduction of a completely new addition to the codebase Type: Testing 🧪 Add testing or improving existing testing of a file, feature, or codebase
Milestone
v1.0 Release

Comments

@chinmayshah99
Copy link
Member

Feature Description

All python code is made mypy complaint. It would be great if we could add mypy tests as part of github actions.

Is your feature request related to a problem?

A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

What alternatives have you considered?

A clear and concise description of any alternative solutions or features you've considered.

Additional Context

Add any other context or screenshots about the feature request here.
@chinmayshah99 chinmayshah99 added Type: New Feature ➕ Introduction of a completely new addition to the codebase Type: Testing 🧪 Add testing or improving existing testing of a file, feature, or codebase labels Aug 16, 2020
@chinmayshah99 chinmayshah99 added this to the v1.0 Release milestone Aug 16, 2020
@alejandrosame alejandrosame mentioned this issue Sep 13, 2020
Open
6 tasks
@chinmayshah99 chinmayshah99 added the Hacktoberfest Open for hacktoberfest 2020 label Oct 1, 2020
@chinmayshah99 chinmayshah99 mentioned this issue Oct 11, 2020
Merged
4 tasks
dvadym pushed a commit to dvadym/PyDP that referenced this issue Jul 3, 2022
@monsieurmuffin
Fix links in the restaurant colab (OpenMined#251)
87b74de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Hacktoberfest Open for hacktoberfest 2020 Type: New Feature ➕ Introduction of a completely new addition to the codebase Type: Testing 🧪 Add testing or improving existing testing of a file, feature, or codebase
Projects
None yet
Milestone
v1.0 Release
Development

Successfully merging a pull request may close this issue.

Added mypy support chinmayshah99/PyDP
1 participant
@chinmayshah99