Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added mypy support #308

Merged
merged 5 commits into from
Oct 13, 2020
Merged

Added mypy support #308

merged 5 commits into from
Oct 13, 2020

Conversation

chinmayshah99
Copy link
Member

@chinmayshah99 chinmayshah99 commented Oct 11, 2020 •
edited
Loading

Description

fixes #251

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

  • tests run locally

Checklist

@chinmayshah99 chinmayshah99 added the Type: Improvement 📈 Performance improvement not introducing a new feature or requiring a major refactor label Oct 11, 2020
@chinmayshah99
Copy link
Member Author

The failed test shows that black doesn't work with py35. But since it's a development dependency, we are good to go :D

@chinmayshah99 chinmayshah99 merged commit 7062da2 into OpenMined:dev Oct 13, 2020
@chinmayshah99 chinmayshah99 deleted the mypy branch November 8, 2020 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alejandrosame alejandrosame Awaiting requested review from alejandrosame

Assignees
No one assigned
Labels
Type: Improvement 📈 Performance improvement not introducing a new feature or requiring a major refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add mypy to tests
1 participant
@chinmayshah99