Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VM keys in Goca Template are not up to date for OS Vector #6782

Closed
jaypif opened this issue Nov 8, 2024 · 0 comments
Closed

VM keys in Goca Template are not up to date for OS Vector #6782

jaypif opened this issue Nov 8, 2024 · 0 comments
Assignees

Comments

@jaypif
Copy link
Contributor

jaypif commented Nov 8, 2024

Description
Based on the documentation page: https://docs.opennebula.io/6.10/management_and_operations/references/template.html?highlight=firmware#os-and-boot-options-section
The OSVec struct in the Goca are not accurate.
Firmware values are missing

Here is the current state in the one/src/oca/go/src/goca/schemas/vm/keys/template.go file:

type OS string

	OSVec string = "OS"

	Arch       OS = "ARCH"
	Machine    OS = "MACHINE"
	Kernel     OS = "KERNEL"
	KernelDS   OS = "KERNEL_DS"
	Initrd     OS = "INITRD"
	InitrdDS   OS = "INITRD_DS"
	Root       OS = "ROOT"
	KernelCmd  OS = "KERNEL_CMD"
	Bootloader OS = "BOOTLOADER"
	Boot       OS = "BOOT"
)```

**Use case**
This is required by recent OS with UEFI boot for example.


**Interface Changes**
no change, just align the OSVec structure with the documentation

**Additional Context**
Terraform provider can be updated to reflect automatically changes in Goca.

<!--////////////////////////////////////////////-->
<!-- THIS SECTION IS FOR THE DEVELOPMENT TEAM   -->
<!-- BOTH FOR BUGS AND ENHANCEMENT REQUESTS     -->
<!-- PROGRESS WILL BE REFLECTED HERE            -->
<!--////////////////////////////////////////////-->

## Progress Status
- [ ] Code committed
- [ ] Testing - QA
- [ ] Documentation (Release notes - resolved issues, compatibility, known issues)
jaypif added a commit to OpenNebula/terraform-provider-opennebula that referenced this issue Nov 8, 2024
This commit adds support for missing OS section in VM template.
It aligns the OS section with the Documentation:
https://docs.opennebula.io/6.10/management_and_operations/references/template.html?highlight=firmware#os-and-boot-options-section

A correct fix consist in updating GOCA OSVec structure to reflec the
Documentation
A dedicated issue has bee openned in the Goca Repo:
OpenNebula/one#6782

Closes: F-558
jaypif added a commit to OpenNebula/terraform-provider-opennebula that referenced this issue Nov 8, 2024
This commit adds support for missing OS section in VM template.
It aligns the OS section with the Documentation:
https://docs.opennebula.io/6.10/management_and_operations/references/template.html?highlight=firmware#os-and-boot-options-section

A correct fix consist in updating GOCA OSVec structure to reflec the
Documentation
A dedicated issue has bee openned in the Goca Repo:
OpenNebula/one#6782

Closes: F-558
jaypif added a commit to OpenNebula/terraform-provider-opennebula that referenced this issue Nov 8, 2024
This commit adds support for missing OS section in VM template.
It aligns the OS section with the Documentation:
https://docs.opennebula.io/6.10/management_and_operations/references/template.html?highlight=firmware#os-and-boot-options-section

A correct fix consist in updating GOCA OSVec structure to reflec the
Documentation
A dedicated issue has bee openned in the Goca Repo:
OpenNebula/one#6782

Closes: F-558
jaypif added a commit to OpenNebula/terraform-provider-opennebula that referenced this issue Nov 8, 2024
This commit adds support for missing OS section in VM template.
It aligns the OS section with the Documentation:
https://docs.opennebula.io/6.10/management_and_operations/references/template.html?highlight=firmware#os-and-boot-options-section

A correct fix consist in updating GOCA OSVec structure to reflec the
Documentation
A dedicated issue has bee openned in the Goca Repo:
OpenNebula/one#6782

Closes: F-558
jaypif added a commit to OpenNebula/terraform-provider-opennebula that referenced this issue Nov 8, 2024
This commit adds support for missing OS section in VM template.
It aligns the OS section with the Documentation:
https://docs.opennebula.io/6.10/management_and_operations/references/template.html?highlight=firmware#os-and-boot-options-section

A correct fix consist in updating GOCA OSVec structure to reflec the
Documentation
A dedicated issue has bee openned in the Goca Repo:
OpenNebula/one#6782

Closes: F-558
jaypif added a commit to OpenNebula/terraform-provider-opennebula that referenced this issue Nov 8, 2024
This commit adds support for missing OS section in VM template.
It aligns the OS section with the Documentation:
https://docs.opennebula.io/6.10/management_and_operations/references/template.html?highlight=firmware#os-and-boot-options-section

A correct fix consist in updating GOCA OSVec structure to reflec the
Documentation
A dedicated issue has bee openned in the Goca Repo:
OpenNebula/one#6782

Closes: F-558
jaimecb added a commit to jaimecb/one that referenced this issue Nov 18, 2024
Signed-off-by: Jaime <jconchello@opennebula.io>
@jaimecb jaimecb self-assigned this Nov 18, 2024
rsmontero added a commit to OpenNebula/docs that referenced this issue Nov 20, 2024
rsmontero pushed a commit that referenced this issue Nov 20, 2024
Signed-off-by: Jaime <jconchello@opennebula.io>
@dcarracedo dcarracedo added this to the Release 6.10.2 milestone Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants