F #3112: Manage IPs for vCenter imported VMs

[sergiojvg]

No description provided.

[tinova]

Please consider a refactor in the vm_template.rb code, a proposal follows:

#Network is already in OpenNebula
if network_found
    nic_tmp = "NIC=[\n"
    nic_tmp << "NETWORK_ID=\"#{network_found["ID"]}\",\n"

    ipv4, ipv6 = find_ips_in_network(network_found, vm_object) if vm?
end


def find_ips_in_network(network, vm_object)
        ipv4 = ipv6 = ""
        return if !vm_object.is_a?(VCenterDriver::VirtualMachine)

        # Refresh OpenNebula network
        network.info
            
        # Iterate over Retrieve vCenter VM NICs
        vm_object.item.guest.net.each do |net|
            if nic[:mac] == net.macAddress
                net.ipConfig.ipAddress.each do |ip_config|
                    ip = IPAddr.new(ip_config.ipAddress)
                    ar_array = network.to_hash['VNET']['AR_POOL']['AR']
                    ar_array = [ar_array] if ar_array.is_a?(Hash)
                        ipv4, ipv6 = find_ip_in_ar(ip, ar_array) if ar_array
                 end
            
                break
            end
        end

        return ipv4, ipv6
    end


    def find_ip_in_ar(ip, ar_array)
        ipv4 = ipv6 = ""
        ar_array.each do |ar|
            if ar.key?('IP') && ar.key?('IP_END')
                start_ip = IPAddr.new(ar['IP'])
                end_ip = IPAddr.new(ar['IP_END'])
                if ip.family == start_ip.family && 
                   ip.family == end_ip.family
                    if ip > start_ip && ip < end_ip
                        ipv4 = ip.to_s if ip.ipv4?
                        ipv6 = ip.to_s if ip.ipv6?
                    end
                end
            end
        end

        return ipv4, ipv6
    end

[tinova]

Also, to one-5.8