Contribute: zfs driver and zfs driver shared over ISCSI #5654

openmilanese · 2021-11-29T16:48:50Z

I make available my integration work on zfs, based on the ceph driver.

zfs is for single node and zfs_iscsi for shared

https://github.com/openmilanese/zfs_iscsi.git
https://github.com/openmilanese/zfs.git

tinova · 2022-04-25T08:55:17Z

src/fireedge/etc/sunstone/admin/user-tab.yaml

+    enabled: true
+    actions:
+      change_authentication: true
+      update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:01Z

src/sunstone/etc/sunstone-views/mixed/user.yaml

+      settings_auth_tab: true
+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:03Z

src/sunstone/etc/sunstone-views/mixed/cloud.yaml

+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:06Z

src/sunstone/etc/sunstone-views/kvm/groupadmin.yaml

+      settings_auth_tab: true
+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:08Z

src/sunstone/etc/sunstone-views/mixed/admin.yaml

+      User.two_factor_auth: true
+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:10Z

src/sunstone/etc/sunstone-views/vcenter/groupadmin.yaml

+      settings_auth_tab: true
+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:12Z

src/sunstone/etc/sunstone-views/vcenter/cloud.yaml

+      settings_showback_tab: true
+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:15Z

src/sunstone/etc/sunstone-views/vcenter/groupadmin.yaml

+      User.two_factor_auth: true
+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:17Z

src/sunstone/etc/sunstone-views/kvm/cloud.yaml

+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:19Z

src/sunstone/etc/sunstone-views/mixed/user.yaml

+      User.two_factor_auth: true
+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:21Z

src/sunstone/etc/sunstone-views/vcenter/groupadmin.yaml

+    actions:
+      User.refresh: true
+      User.create_dialog: true
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:24Z

src/sunstone/etc/sunstone-views/kvm/admin.yaml

+      settings_auth_tab: true
+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:26Z

src/sunstone/etc/sunstone-views/mixed/user.yaml

+    actions:
+      User.refresh: true
+      User.create_dialog: true
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:28Z

src/sunstone/etc/sunstone-views/kvm/cloud.yaml

+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:30Z

src/sunstone/etc/sunstone-views/kvm/groupadmin.yaml

+      User.two_factor_auth: true
+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:32Z

src/sunstone/etc/sunstone-views/kvm/user.yaml

+    actions:
+      User.refresh: true
+      User.create_dialog: true
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:35Z

src/sunstone/etc/sunstone-views/vcenter/user.yaml

+    actions:
+      User.refresh: true
+      User.create_dialog: true
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:37Z

src/sunstone/etc/sunstone-views/mixed/admin.yaml

+    actions:
+      User.refresh: true
+      User.create_dialog: true
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:39Z

src/sunstone/etc/sunstone-views/vcenter/admin.yaml

+      User.two_factor_auth: true
+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:42Z

src/sunstone/etc/sunstone-views/kvm/groupadmin.yaml

+    actions:
+      User.refresh: true
+      User.create_dialog: true
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:45Z

src/sunstone/etc/sunstone-views/mixed/cloud.yaml

+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

Signed-off-by: Victor Hansson <vhansson@opennebula.io>

This commit solves the problem by improving the overflow in integer types Signed-off-by: Valentyn Bohdan <vbohdan@opennebula.io>

Signed-off-by: Valentyn Bohdan <vbohdan@opennebula.io> Co-authored-by: Pavel Czerny <pczerny@opennebula.io>

(cherry picked from commit a158b0ed07546c1ff67915aabbf620131de0383b)

Co-authored-by: Tino Vázquez <cvazquez@opennebula.io>

Signed-off-by: Ángel Cívico Martos <acivico@opennnebula.io>

Signed-off-by: Pedro Ielpi <pielpi@opennebula.io>

This is the first version of a ScaleWay drivers for OneProvision. The drivers include the following features: - Full support for defining Scaleway zones and regions, predefined files for Paris-1, Amsterdam-1 and Warsaw-3. - Edge cluster based on metal instances - Flexible IP support for VMs running on Scaleway clusters - Private networking based on VXLAN and FRR (bgp-evpn). Future versions of this driver will consider extending IPAM to use Scaleway private networks. - Playbook includes an /etc/hosts update to support name resolution of scaleway instances (needed by libvirt for live migration) This commit also updates firewall to allow libvirt ports. co-authored-by: Victor Palma <vpalma@opennebula.io>

Signed-off-by: dcarracedo <dcarracedo@opennebula.io>

- Missing files in install.sh - Fix bug in unregister_address_range

(cherry picked from commit b58d3399e2067f972b456f5202bf18fe1ed0e4e2)

on image config file Signed-off-by: Ángel Cívico Martos <acivico@opennnebula.io>

Signed-off-by: dcarracedo <dcarracedo@opennebula.io> Co-authored-by: Tino Vázquez <cvazquez@opennebula.io>

Signed-off-by: Victor Hansson <vhansson@opennebula.io>

This commit adds the following features using the vlan_filter capabilities of the Linux Bridge: * 802.1Q driver, support for QinQ. This is not a full implementation compared to the vSwitch as there is no native support in the linux bridge: - VLAN_ID is the (outer/C-VLAN) tag implemented by tagging the PHY_DEV interface - CVLANS are the customer tags, any other VLAN is filtered out in the bridge * bridge driver, support for vlan filtering (VLAN_TAGGED_ID) only the specified tags are allowed in the trunk. Additionally this commits includes linting of some files. (cherry picked from commit e379bd66842dc4aa256e1c503ca425553d02bf9b)

Signed-off-by: Valentyn Bohdan <vbohdan@opennebula.io>

Signed-off-by: Victor Hansson <vhansson@opennebula.io> Co-authored-by: Tino Vázquez <cvazquez@opennebula.io>

Ensure that OpenNebula will: configure the VM with CPU affinity to the auto-selected NUMA node Signed-off-by: Kristian Feldsam <feldsam@gmail.com> (cherry picked from commit c6adde2) (cherry picked from commit a456c817d018281b4678480066add9baba3af16c)

* Adds vGPU profiles to dummy driver * Adds back in missing vGPU selector to Sunstone Signed-off-by: Victor Hansson <vhansson@opennebula.io>

(cherry picked from commit c395b0024f43b28ca9b6e7313314c88c58444e82)

Current version of the drivers does not check for user input to have the right format

* Improve qemu-ga monitoring resilience * Add more commands to config files

Updating ACKs to new format.

rsmontero force-pushed the master branch 4 times, most recently from 0b269ff to b94dad5 Compare December 14, 2021 16:49

rsmontero force-pushed the master branch from 2377a4e to 995f2d1 Compare March 25, 2022 13:00

tinova reviewed Apr 25, 2022

View reviewed changes

rsmontero force-pushed the master branch 2 times, most recently from 9e1985e to d019bd4 Compare April 28, 2022 14:43

rsmontero force-pushed the master branch from e4e6b6c to 04bbc74 Compare July 27, 2022 14:32

rsmontero force-pushed the master branch from 2024f62 to 3f300f3 Compare October 6, 2022 09:08

tinova reviewed Oct 18, 2022

View reviewed changes

vichansson and others added 30 commits November 27, 2024 11:30

B #-: Fixes null check for appConfig (#3310)

ee25fdc

Signed-off-by: Victor Hansson <vhansson@opennebula.io>

B #6750: Fix iotune attributes not being passed to VM

c5ef443

This commit solves the problem by improving the overflow in integer types Signed-off-by: Valentyn Bohdan <vbohdan@opennebula.io>

F #6771: Replace deprecated OpenSSL function calls. (#3297)

478c156

Signed-off-by: Valentyn Bohdan <vbohdan@opennebula.io> Co-authored-by: Pavel Czerny <pczerny@opennebula.io>

L #-: Update to rubocop 1.69.0

d8d4c3b

(cherry picked from commit a158b0ed07546c1ff67915aabbf620131de0383b)

F #6771: Fix build for older OpenSSL versions (#3311)

c124e43

M #~: fix file tab (#3312)

b8c2f60

M #-: Fix FireEdge service tests (#3313)

b228af1

Co-authored-by: Tino Vázquez <cvazquez@opennebula.io>

M #~: Fix provision/provider tests (#3315)

feb2fe7

B #6768: Fix filtering by locked/unlocked (#3303)

ecdee7e

Signed-off-by: Ángel Cívico Martos <acivico@opennnebula.io>

M #-: Append ACK to README

0d41fe3

Signed-off-by: Pedro Ielpi <pielpi@opennebula.io>

M #-: Fix bug in the sec groups tables (#3317)

f1a0c4e

Signed-off-by: dcarracedo <dcarracedo@opennebula.io>

F #6756: Add files to installer

450563d

F #6756: Fix for Scaleway driver

d546ed3

- Missing files in install.sh - Fix bug in unregister_address_range

F #6756: Fix Scaleway render

55ad489

B #-: Update AWS elastic driver to new Ruby gem interface

a4f8121

(cherry picked from commit b58d3399e2067f972b456f5202bf18fe1ed0e4e2)

B #6768: Adding filters locked (#3320)

014bd1f

on image config file Signed-off-by: Ángel Cívico Martos <acivico@opennnebula.io>

M #~: fix NETWORK_ID when attach network (#3322)

0609730

B #6817: Image dev_prefix must be lowercase (#3323)

0f85667

Signed-off-by: dcarracedo <dcarracedo@opennebula.io> Co-authored-by: Tino Vázquez <cvazquez@opennebula.io>

B #6788: Fix host graph API call (#3324)

7161126

Signed-off-by: Victor Hansson <vhansson@opennebula.io>

B #6759: Add extra checks for ports in SecurityGroup validation (#3319)

5aebf69

Signed-off-by: Valentyn Bohdan <vbohdan@opennebula.io>

B #6757: Add missing boot order (#3325)

983d797

Signed-off-by: Victor Hansson <vhansson@opennebula.io> Co-authored-by: Tino Vázquez <cvazquez@opennebula.io>

B #6293: Add vGPU profile selector (#3326)

67c99ab

* Adds vGPU profiles to dummy driver * Adds back in missing vGPU selector to Sunstone Signed-off-by: Victor Hansson <vhansson@opennebula.io>

F #6669: Fix typo in update function

0fde09b

(cherry picked from commit c395b0024f43b28ca9b6e7313314c88c58444e82)

F #6669: Fix regexp to detect port ranges

8ff4b90

Current version of the drivers does not check for user input to have the right format

B #6765: Improve QEMU Guest Agent monitoring. (#3328)

fcd8eb0

* Improve qemu-ga monitoring resilience * Add more commands to config files

M #-: Add additional comments for VXLAN-EVPN configuration

0a47acf

M #-: Change ACKs in Readme file (#3327)

ebc5b95

Updating ACKs to new format.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Contribute: zfs driver and zfs driver shared over ISCSI #5654

Contribute: zfs driver and zfs driver shared over ISCSI #5654

openmilanese commented Nov 29, 2021 •

edited

Loading

tinova Apr 25, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

tinova Oct 18, 2022

Contribute: zfs driver and zfs driver shared over ISCSI #5654

Are you sure you want to change the base?

Contribute: zfs driver and zfs driver shared over ISCSI #5654

Conversation

openmilanese commented Nov 29, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

openmilanese commented Nov 29, 2021 •

edited

Loading