Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribute: zfs driver and zfs driver shared over ISCSI #5654

Open
wants to merge 2,008 commits into
base: one-6.2
Choose a base branch
from

M #-: Change ACKs in Readme file (#3327)

ebc5b95
Select commit
Loading
Failed to load commit list.
Open

Contribute: zfs driver and zfs driver shared over ISCSI #5654

M #-: Change ACKs in Readme file (#3327)
ebc5b95
Select commit
Loading
Failed to load commit list.
DCO / DCO required action Dec 17, 2024 in 4s

DCO

There are 8 commits incorrectly signed off. This means that the author(s) of these commits failed to include a Signed-off-by line in their commit message.

To avoid having PRs blocked in the future, always include Signed-off-by: Author Name <authoremail@example.com> in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).

Here is how to fix the problem so that this code can be merged.

Rebase the branch

If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").

You should only do this if:

  • You are the only author of the commits in this branch
  • You are absolutely certain nobody else is doing any work based upon this branch
  • There are no empty commits in the branch (for example, a DCO Remediation Commit which was added using --allow-empty)

To add your Signed-off-by line to every commit in this branch:

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git rebase HEAD~250 --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin master

Summary

Commit sha: 34ccd72, Author: Anton Todorov, Committer: Tino Vázquez; The sign-off is missing.
Commit sha: d5b5a4d, Author: Anton Todorov, Committer: Ruben S. Montero; The sign-off is missing.
Commit sha: f698097, Author: Daniel Clavijo Coca, Committer: Ruben S. Montero; Commit by organization member is not verified.
Commit sha: 1607b4a, Author: marchenkov.s, Committer: Ruben S. Montero; The sign-off is missing.
Commit sha: fb715c3, Author: Pavel Czerny, Committer: Ruben S. Montero; Commit by organization member is not verified.
Commit sha: 0357ffb, Author: Pavel Czerny, Committer: Ruben S. Montero; Commit by organization member is not verified.
Commit sha: 822581a, Author: Shanobi, Committer: Ruben S. Montero; The sign-off is missing.
Commit sha: d8d4c3b, Author: Tino Vázquez, Committer: Tino Vázquez; Commit by organization member is not verified.

View more details on DCO