Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strings 3078–3089 have moved #1625

Open
14 of 19 tasks
Gymnasiast opened this issue Dec 18, 2018 · 5 comments
Open
14 of 19 tasks

Strings 3078–3089 have moved #1625

Gymnasiast opened this issue Dec 18, 2018 · 5 comments

Comments

@Gymnasiast
Copy link
Member

Gymnasiast commented Dec 18, 2018

Moved strings from PR OpenRCT2/OpenRCT2#7961.

The following lines should be removed from the translation files here:

-STR_3078    :Plain entrance
-STR_3079    :Wooden entrance
-STR_3080    :Canvas tent entrance
-STR_3081    :Castle entrance (grey)
-STR_3082    :Castle entrance (brown)
-STR_3083    :Jungle entrance
-STR_3084    :Log cabin entrance
-STR_3085    :Classical/Roman entrance
-STR_3086    :Abstract entrance
-STR_3087    :Snow/Ice entrance
-STR_3088    :Pagoda entrance
-STR_3089    :Space entrance

And you should add them to the station files in the objects repository, found at https://github.com/OpenRCT2/objects/tree/master/objects/rct2/station and https://github.com/OpenRCT2/objects/tree/master/objects/official/station .

Updated in:

  • ar-EG
  • ca-ES
  • cs-CZ
  • da-DK
  • de-DE
  • en-US
  • es-ES
  • fr-FR
  • hu-HU
  • it-IT
  • ja-JP
  • ko-KR
  • nb-NO
  • nl-NL
  • pt-BR
  • sv-SE
  • tr-TR
  • zh-CN
  • zh-TW

Notification when new strings arrive:
@Nubbie @Goddesen @octaroot @telk5093 @Omaranwa @danidoedel @LPSGizmo @BobbyS38 @frenchiveruti @anon569

@frenchiveruti
Copy link
Contributor

Ok I have to ask why do you take the approach of having each file translating the string instead of a monolithic file with all the translations in it.
It's easier for me to spot a wrong translation and find it instead of having to seathe through multiple files, I think it's a bad approach regarding translation.

@Gymnasiast
Copy link
Member Author

Because those JSON objects contain a lot more than just translations. From a technical viewpoint, this approach is better. I perfectly understand why you don't find it easy to work with - but that would be better solved by improved tools, rather than putting them back in monolithic files.

Gymnasiast pushed a commit that referenced this issue Dec 19, 2018
@frenchiveruti
Copy link
Contributor

Because those JSON objects contain a lot more than just translations. From a technical viewpoint, this approach is better. I perfectly understand why you don't find it easy to work with - but that would be better solved by improved tools, rather than putting them back in monolithic files.

I understand.

Gymnasiast pushed a commit that referenced this issue Dec 28, 2018
Goddesen pushed a commit to Goddesen/objects that referenced this issue Jan 26, 2019
Goddesen pushed a commit to Goddesen/OpenRCT2-Localisation that referenced this issue Jan 26, 2019
Gymnasiast pushed a commit to OpenRCT2/objects that referenced this issue Jan 27, 2019
Gymnasiast pushed a commit that referenced this issue Jan 27, 2019
Gymnasiast pushed a commit that referenced this issue Feb 13, 2019
Gymnasiast pushed a commit to OpenRCT2/objects that referenced this issue Feb 13, 2019
@ghost ghost mentioned this issue Mar 10, 2019
@Wuzzy2
Copy link
Contributor

Wuzzy2 commented Jun 4, 2020

en-US is already done.

@AaronVanGeffen AaronVanGeffen changed the title Strings have moved Strings 3078–3089 have moved Jun 4, 2020
@galfisk
Copy link
Contributor

galfisk commented Feb 1, 2021

Applied to sv-SE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants