Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zh-TW: Massive Catch-up #1837

Merged
merged 2 commits into from
Mar 28, 2020
Merged

zh-TW: Massive Catch-up #1837

merged 2 commits into from
Mar 28, 2020

Conversation

daihakken
Copy link
Contributor

@daihakken daihakken commented Mar 28, 2020

Hi! Sorry for disappeared for so long due to real-life situations. Finally I can start updating from this quarantine...

Applying for issue(s):

Not applied:

P.S. May somebody explain me in short for the translations needed for object JSONs?

@Gymnasiast Gymnasiast merged commit 402a657 into OpenRCT2:master Mar 28, 2020
@tupaschoal
Copy link
Member

Welcome back @daihakken !

So if you go to OpenRCT2/objects you will see that there are lots of JSON files with localisation strings. Like:

https://github.com/OpenRCT2/objects/blob/9739079f771b3d415dbc36a8e16a2e7018071a9a/objects/rct2tt/ride/rct2.tt.trilobte.json#L71-L114

Is that what you were asking?

@Gymnasiast
Copy link
Member

Gymnasiast commented Mar 28, 2020

Welcome back!

The JSON objects are here: https://github.com/OpenRCT2/objects/tree/master/objects

They don't change very often, so there aren't many changes you need to apply. What do you need to do is check if every object has a zh-TW translation - most likely, some still lack one. #1625 also provides some strings you need to apply (and remove here).

@AaronVanGeffen
Copy link
Member

To add to the above, there are helper scripts available to ease the object translation process. Let us know if you need any help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants