Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pt-BR: Apply #2121 #2128

Merged
merged 3 commits into from
Jan 29, 2021
Merged

pt-BR: Apply #2121 #2128

merged 3 commits into from
Jan 29, 2021

Conversation

tupaschoal
Copy link
Member

Applying for issue(s):

@github-actions
Copy link

Check results

For details go to Translation Check -> Details. Expand Run checks build stage and use the build-in search to find your language (e.g. pl-PL)

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exits in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)
pt-BR 0 0 122

Other translations

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exits in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)
ar-EG 281 0 2172
ca-ES 31 0 122
cs-CZ 301 0 266
da-DK 12 0 569
de-DE 0 0 320
en-US 3299 0 390
eo-OO 0 0 80
es-ES 21 0 290
fi-FI 1229 0 397
fr-FR 2 0 152
hu-HU 229 0 104
it-IT 33 0 312
ja-JP 54 7 642
ko-KR 0 0 188
nb-NO 275 0 2116
nl-NL 0 12 438
pl-PL 0 0 450
ru-RU 1358 0 143
sv-SE 105 0 343
tr-TR 146 7 425
zh-CN 127 0 451
zh-TW 72 0 312

Gymnasiast
Gymnasiast reviewed Jan 26, 2021
View reviewed changes
objects/pt-BR.json Outdated
@@ -1,19 +1,19 @@
{
"rct2.glthent": {
"reference-name": "'Goliath' Sign",
"name": "Placa 'Golias'"
"name": "Placa ‘Golias’"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Goliath" refers to a roller coaster with that name, not to the biblical giant.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Gymnasiast
Copy link
Member

There are still some ' quotes in the scenario translations, for example on line 4458 (Rock 'n' Roll - Rock 'n' Roll).

BTW, strictly speaking, Rock 'n' Roll should be rendered as Rock ’n’ Roll - two apostrophes, since we're omitting letters.

@github-actions
Copy link

Check results

For details go to Translation Check -> Details. Expand Run checks build stage and use the build-in search to find your language (e.g. pl-PL)

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exits in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)
pt-BR 0 0 122

Other translations

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exits in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)
ar-EG 281 0 2172
ca-ES 31 0 122
cs-CZ 301 0 266
da-DK 12 0 569
de-DE 0 0 320
en-US 3299 0 390
eo-OO 0 0 80
es-ES 21 0 290
fi-FI 1229 0 397
fr-FR 2 0 152
hu-HU 229 0 104
it-IT 33 0 312
ja-JP 54 7 642
ko-KR 0 0 188
nb-NO 275 0 2116
nl-NL 0 12 438
pl-PL 0 0 450
ru-RU 1358 0 143
sv-SE 105 0 343
tr-TR 146 7 425
zh-CN 127 0 451
zh-TW 72 0 312

@github-actions
Copy link

Check results

For details go to Translation Check -> Details. Expand Run checks build stage and use the build-in search to find your language (e.g. pl-PL)

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exits in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)
pt-BR 0 0 122

Other translations

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exits in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)
ar-EG 281 0 2172
ca-ES 31 0 122
cs-CZ 301 0 266
da-DK 12 0 569
de-DE 0 0 320
en-US 3299 0 390
eo-OO 0 0 80
es-ES 21 0 290
fi-FI 1229 0 397
fr-FR 2 0 152
hu-HU 229 0 104
it-IT 33 0 312
ja-JP 54 7 642
ko-KR 0 0 188
nb-NO 275 0 2116
nl-NL 0 12 438
pl-PL 0 0 450
ru-RU 1358 0 143
sv-SE 105 0 343
tr-TR 146 7 425
zh-CN 127 0 451
zh-TW 72 0 312

tupaschoal
tupaschoal commented Jan 26, 2021
View reviewed changes
Copy link
Member Author

@tupaschoal tupaschoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the Rock'n'roll tip, I wouldn't have known.

Also, I noticed I had translated some reference keys on the objects file, we gotta pay attention to that.

data/language/pt-BR.txt Show resolved Hide resolved
data/language/pt-BR.txt Show resolved Hide resolved
@tupaschoal tupaschoal requested a review from Gymnasiast January 28, 2021 22:11
Gymnasiast
Gymnasiast reviewed Jan 29, 2021
View reviewed changes
objects/pt-BR.json Outdated Show resolved Hide resolved
@Gymnasiast Gymnasiast merged commit 172fa3d into OpenRCT2:master Jan 29, 2021
@github-actions
Copy link

Check results

For details go to Translation Check -> Details. Expand Run checks build stage and use the build-in search to find your language (e.g. pl-PL)

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exits in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)
pt-BR 0 0 122

Other translations

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exits in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)
ar-EG 281 0 2172
ca-ES 31 0 122
cs-CZ 301 0 266
da-DK 12 0 569
de-DE 0 0 320
en-US 3299 0 390
eo-OO 0 0 80
es-ES 21 0 290
fi-FI 1229 0 397
fr-FR 2 0 152
hu-HU 229 0 104
it-IT 33 0 312
ja-JP 54 7 642
ko-KR 0 0 188
nb-NO 275 0 2116
nl-NL 0 12 438
pl-PL 0 0 450
ru-RU 1358 0 143
sv-SE 105 0 343
tr-TR 146 7 425
zh-CN 127 0 451
zh-TW 72 0 312

@tupaschoal tupaschoal deleted the 2121 branch January 29, 2021 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gymnasiast Gymnasiast Gymnasiast left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tupaschoal @Gymnasiast