Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace typewriter quotes #2121

Open
7 of 21 tasks
Gymnasiast opened this issue Jan 19, 2021 · 15 comments
Open
7 of 21 tasks

Replace typewriter quotes #2121

Gymnasiast opened this issue Jan 19, 2021 · 15 comments

Comments

@Gymnasiast
Copy link
Member

Gymnasiast commented Jan 19, 2021

The straight quotation marks - ' and " - were introduced by typewriters to save space, which carried over to ASCII.

Since the late 90s, there is little need to use them, as proper quotations have been introduced since. For example, this means you should use “ ” and ‘ ’ for quotation marks (at least in English, other languages can have different quotation marks such as « ») and ’ as an apostrophe.

More info can be found here: https://en.wikipedia.org/wiki/Quotation_mark

The typewriter quotes should be replaced everywhere except in technical strings such as <Mel's World>. And if present, the backtick (`) should be replaced with ‘.

Note that you will need to replace the characters in both the interface translation and objects translation.

Updated in:

  • ar-EG
  • ca-ES
  • cs-CZ
  • da-DK
  • de-DE
  • en-US
  • eo-OO
  • es-ES
  • fr-FR
  • hu-HU
  • it-IT
  • ja-JP
  • ko-KR
  • nb-NO
  • nl-NL
  • pl-PL
  • pt-BR
  • sv-SE
  • tr-TR
  • zh-CN
  • zh-TW

Notification when new strings arrive:
@Omaranwa @J0anJosep @octaroot @LPSGizmo @danidoedel @Wuzzy2 @tellovishous @JasperGray @Wirlie @JoelTroch @anon569 @LucaRed @AaronVanGeffen @telk5093 @Goddesen @Gymnasiast @renansimoes @tupaschoal @Nubbie @izhangfei @daihakken @marcinkunert

Gymnasiast added a commit that referenced this issue Jan 19, 2021
@tupaschoal tupaschoal assigned tupaschoal and unassigned tupaschoal Jan 19, 2021
telk5093 added a commit to telk5093/Localisation that referenced this issue Jan 20, 2021
Gymnasiast pushed a commit that referenced this issue Jan 20, 2021
@Wuzzy2
Copy link
Contributor

Wuzzy2 commented Jan 21, 2021

I also like to add: The ASCII apostrophe (U+0027) can be replaced with U+2019: https://en.wikipedia.org/wiki/%E2%80%99

@Gymnasiast
Copy link
Member Author

I also like to add: The ASCII apostrophe (U+0027) can be replaced with U+2019: https://en.wikipedia.org/wiki/%E2%80%99

I already said that in the opening post:

For example, this means you should use “ ” and ‘ ’ for quotation marks ... and ’ as an apostrophe.

Gymnasiast pushed a commit that referenced this issue Jan 23, 2021
tupaschoal added a commit to tupaschoal/Localisation that referenced this issue Jan 25, 2021
tupaschoal added a commit to tupaschoal/Localisation that referenced this issue Jan 26, 2021
Gymnasiast pushed a commit that referenced this issue Jan 29, 2021
@galfisk
Copy link
Contributor

galfisk commented Feb 1, 2021

Applied to sv-SE

@Gymnasiast
Copy link
Member Author

@galfisk Also to the objects translation?

@galfisk
Copy link
Contributor

galfisk commented Feb 1, 2021

@Gymnasiast to everything in the sv-SE file apart from the technical strings, by search-and-replace.

@Gymnasiast
Copy link
Member Author

@galfisk
Copy link
Contributor

galfisk commented Feb 1, 2021

Aha, I didn't know about that one. Should I replace quotes only inside the string after "name": ? Can there be any double quotes in there, or are there single quote marks/apostrophes only?

@Gymnasiast
Copy link
Member Author

Leave everything with reference in the field name as-is, but change the rest (name, description, capacity, ...). It is possible that there are double quotes, but those will be encoded as \", so you can search for that.

@galfisk
Copy link
Contributor

galfisk commented Feb 2, 2021

Are the non-reference fields supposed to be direct translations of the corresponding reference fields? It seems that way in the en-GB file, but in the sv-SE file some of them are quite a bit different, and in at least one case completely unrelated. I can fix this if needed.

@Gymnasiast
Copy link
Member Author

Yes, they are supposed to be direct translations.

It seems that way in the en-GB file

That file was included by mistake: en-GB is the source language, so every single translation will be equal to the reference.

, but in the sv-SE file some of them are quite a bit different, and in at least one case completely unrelated. I can fix this if needed.

Please do!

@galfisk
Copy link
Contributor

galfisk commented Feb 3, 2021

Is there a need for keeping the entries in this file arranged in a specific order? It would be a whole lot easier to keep translations consistent if I could, for instance, group the trains for a specific rollercoaster together like in the object picker. Now they're spread all over. Even entries like rct2.mono1/2/3 are in completely different places.
Edit: I've done a first pass and fixed a lot of stuff, but this would be very useful when doing a second fixing, tweaking and consistency pass. I've also tweaked sv-SE.txt to match some stuff in the .json.

@Gymnasiast
Copy link
Member Author

I'm afraid the order has to stay. It's not ideal, and we should really have something like a webtranslator or some other tooling, but that in turn requires us to either switch to a translation system that is supported by standard tools or write something of our own.

@galfisk
Copy link
Contributor

galfisk commented Feb 4, 2021

I understand. I'll do what I can to provide a good translation, but it'll take more time. You should probably consider such a system though, it'd make quality translation work a lot easier if done right.

@Gymnasiast
Copy link
Member Author

Well, you're preaching to the choir ;-)

The problem is that I already have so much to do (my day job, OpenRCT2 and several other commitments), which means big projects like this are difficult to pick up. Especially since the current system does work, even if it is sometimes cumbersome to work with. I do plan to look into translations, objects, open scenarios and the documentation once the new save format is there, but that project is dragging on as well.

@galfisk galfisk mentioned this issue Feb 8, 2021
marcinkunert pushed a commit to marcinkunert/OpenRCT2_Localisation that referenced this issue Mar 26, 2021
marcinkunert pushed a commit to marcinkunert/OpenRCT2_Localisation that referenced this issue Mar 26, 2021
marcinkunert pushed a commit to marcinkunert/OpenRCT2_Localisation that referenced this issue Mar 26, 2021
marcinkunert pushed a commit to marcinkunert/OpenRCT2_Localisation that referenced this issue Mar 26, 2021
marcinkunert pushed a commit to marcinkunert/OpenRCT2_Localisation that referenced this issue Mar 26, 2021
marcinkunert added a commit to marcinkunert/OpenRCT2_Localisation that referenced this issue Mar 26, 2021
marcinkunert added a commit to marcinkunert/OpenRCT2_Localisation that referenced this issue Mar 26, 2021
marcinkunert added a commit to marcinkunert/OpenRCT2_Localisation that referenced this issue Mar 26, 2021
Gymnasiast pushed a commit that referenced this issue Mar 26, 2021
@OmarAglan
Copy link
Contributor

Well This Issue In Not A Big Problem In Arabic, should I get it ticked or what?

martinpalic added a commit to martinpalic/RCT2Localisation that referenced this issue Nov 3, 2022
martinpalic added a commit to martinpalic/RCT2Localisation that referenced this issue Nov 3, 2022
Gymnasiast pushed a commit that referenced this issue Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants