Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ar-EG.txt (Don't Merge It yet!) #2568

Merged
merged 2 commits into from
Feb 20, 2023
Merged

Conversation

@github-actions
Copy link

Check results

For details go to Translation Check -> Details. Expand Run checks build stage and use the build-in search to find your language (e.g. pl-PL)

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exits in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)

ar-EG 26 (-80) 1 1961

Other translations

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exits in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)

ca-ES 6 0 113
cs-CZ 333 0 246
da-DK 71 0 484
de-DE 10 0 345
en-US 3329 0 390
eo-ZZ 6 0 87
es-ES 6 0 299
fi-FI 105 0 109
fr-CA 3913 0 0
fr-FR 0 0 159
hu-HU 123 0 110
it-IT 82 0 300
ja-JP 248 0 609
ko-KR 2 0 193
nb-NO 260 0 2166
nl-NL 6 12 442
pl-PL 90 0 381
pt-BR 0 0 144
ru-RU 1438 0 105
sv-SE 112 0 341
tr-TR 311 0 396
vi-VN 170 2 3262
zh-CN 8 0 93
zh-TW 66 0 332

Copy link
Member

@tupaschoal tupaschoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some issues had already been done: 2345, 2354, 2363, 2369, 2378, 2399, 2414 . Any reason for including them in the PR description? (I have edited the description for now to distinguish)

Aside from that everything that is in the diff seems to be ok, can you elaborate on why to wait for merge?

data/language/ar-EG.txt Show resolved Hide resolved
@OmarAglan
Copy link
Contributor Author

OmarAglan commented Jan 25, 2023

Some issues had already been done: 2345, 2354, 2363, 2369, 2378, 2399, 2414 . Any reason for including them in the PR description? (I have edited the description for now to distinguish)

Aside from that everything that is in the diff seems to be ok, can you elaborate on why to wait for merge?

the thing is that these issues are done, but not marked!
I had to add them for reference.

  • for the WIP, I plan to add more in-line translations in the coming days!

@tupaschoal
Copy link
Member

  • for the WIP, I plan to add more in-line translations in the coming days!

Ok! I'll mark the PR as draft in the meantime, but feel free to mark it as ready for review when you finish! Keep in mind that it is better for us to do small batches than to do one big chunk :)

@tupaschoal tupaschoal marked this pull request as draft January 25, 2023 23:59
@OmarAglan
Copy link
Contributor Author

  • for the WIP, I plan to add more in-line translations in the coming days!

Ok! I'll mark the PR as draft in the meantime, but feel free to mark it as ready for review when you finish! Keep in mind that it is better for us to do small batches than to do one big chunk :)

  • for the WIP, I plan to add more in-line translations in the coming days!

Ok! I'll mark the PR as draft in the meantime, but feel free to mark it as ready for review when you finish! Keep in mind that it is better for us to do small batches than to do one big chunk :)

Ok, Thanks for that fast reply, this pull is a rewrite of some sentences here and there, plus some more strings in line with other strings (a lot of words have a double meaning, which makes the translation weird).

@github-actions
Copy link

Check results

For details go to Translation Check -> Details. Expand Run checks build stage and use the build-in search to find your language (e.g. pl-PL)

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exits in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)

ar-EG 23 (-83) 1 1957 (-4)

Other translations

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exits in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)

ca-ES 6 0 113
cs-CZ 333 0 246
da-DK 71 0 484
de-DE 10 0 345
en-US 3329 0 390
eo-ZZ 6 0 87
es-ES 6 0 299
fi-FI 105 0 109
fr-CA 3913 0 0
fr-FR 0 0 159
hu-HU 123 0 110
it-IT 82 0 300
ja-JP 248 0 609
ko-KR 2 0 193
nb-NO 260 0 2166
nl-NL 6 12 442
pl-PL 90 0 381
pt-BR 0 0 144
ru-RU 1438 0 105
sv-SE 112 0 341
tr-TR 311 0 396
vi-VN 170 2 3262
zh-CN 8 0 93
zh-TW 66 0 332

Copy link
Member

@tupaschoal tupaschoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok up until the last commit (6ec76ef)

@tupaschoal
Copy link
Member

@Omaranwa can we merge this one as is, and then you resume your work on another PR? It's already quite big, it will be easier to review in smaller chunks.

@Gymnasiast Gymnasiast self-requested a review February 15, 2023 10:47
@tupaschoal tupaschoal marked this pull request as ready for review February 20, 2023 09:52
@tupaschoal tupaschoal merged commit ce0fbf9 into OpenRCT2:master Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants