-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ar-EG.txt (Don't Merge It yet!) #2568
Conversation
Check resultsFor details go to
Other translations
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some issues had already been done: 2345, 2354, 2363, 2369, 2378, 2399, 2414 . Any reason for including them in the PR description? (I have edited the description for now to distinguish)
Aside from that everything that is in the diff seems to be ok, can you elaborate on why to wait for merge?
the thing is that these issues are done, but not marked!
|
Ok! I'll mark the PR as draft in the meantime, but feel free to mark it as ready for review when you finish! Keep in mind that it is better for us to do small batches than to do one big chunk :) |
Ok, Thanks for that fast reply, this pull is a rewrite of some sentences here and there, plus some more strings in line with other strings (a lot of words have a double meaning, which makes the translation weird). |
Check resultsFor details go to
Other translations
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems ok up until the last commit (6ec76ef)
@Omaranwa can we merge this one as is, and then you resume your work on another PR? It's already quite big, it will be easier to review in smaller chunks. |
Applying for issue(s):
EDIT (by tupaschoal) - These had already been done previously and are not covered in this PR: