Fix #22316: Always recreate the window when changing drawing engine

[ZehMatt]

We have to always create a new window as SDL has some lingering state left on it even when if we free all SDL related handles.

Closes #22316

[Gymnasiast]

@Basssiiie Does this fix the problem for you?

[Basssiiie]

I have no crashes anymore when switching drawing engines in this build. 🙂

I do get this new stdout error on launch if my drawing engine is set to OpenGL, and occasionally when switching to OpenGL from another drawing engine as well, which I haven't seen before:

ERROR[D:\a\OpenRCT2\OpenRCT2\src\openrct2-ui\drawing\engines\opengl\OpenGLAPI.h:123 (OpenRCT2::Ui::CheckGLError)]: OpenGL Error 0x0501

[Gymnasiast]

I get that error on startup, but also on develop. Occasionally, it even segfaults (again, on develop).

[ZehMatt]

I will have to look into what that error is about, it doesn't seem like there is anything wrong tho.

[Gymnasiast]

Do you want to address that in this PR or in another? Since it happens on develop too, I’m happy to merge this PR as-is.

[Basssiiie]

The error must be quite recent then (~ maybe added past week) because I had not seen it before. 😯

[ZehMatt]

The place where it checks the error is not the actual place where the error is generated, this needs a bit of digging to what specific OpenGL API calls causes that error so I think its best to ignore it for the time being, it might be something related to the line drawing. I think we can merge this as is as the error is not persistent and isn't coming from this PR.

[Basssiiie]

In that case, LGTM!