Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Game crash when switching from "Software" to "Software (Hardware display)" #22316

Closed
Basssiiie opened this issue Jul 16, 2024 · 1 comment · Fixed by #22522
Closed

Game crash when switching from "Software" to "Software (Hardware display)" #22316

Basssiiie opened this issue Jul 16, 2024 · 1 comment · Fixed by #22522
Labels
bug Something went wrong.

Comments

@Basssiiie
Copy link
Member

Operating System

Windows 10, 64-bit

OpenRCT2 build

OpenRCT2, v0.4.12-60-g461b4b9 (461b4b9 on develop) provided by GitHub

Base game

RollerCoaster Tycoon 2

Area(s) with this issue?

No response

Describe the issue

My game crashes when I switch from the "Software" to the "Software (Hardware display)" drawing engine.

I get the following output in my stdout:

WARNING[D:\a\OpenRCT2\OpenRCT2\src\openrct2-ui\drawing\engines\HardwareDisplayDrawingEngine.cpp:103 (HardwareDisplayDrawingEngine::Resize)]: HWDisplayDrawingEngine::Resize error: Parameter 'renderer' is invalid

The second attempt also generated a crash with dump, along side more warnings and errors (probably because of the first warning):

WARNING[D:\a\OpenRCT2\OpenRCT2\src\openrct2\core\Imaging.cpp:55 (Imaging::PngWarning)]: Image width is zero in IHDR
WARNING[D:\a\OpenRCT2\OpenRCT2\src\openrct2\core\Imaging.cpp:55 (Imaging::PngWarning)]: Image height is zero in IHDR
ERROR[D:\a\OpenRCT2\OpenRCT2\src\openrct2\core\Imaging.cpp:60 (Imaging::PngError)]: Invalid IHDR data
openrct2 $ libpng error: Invalid IHDR data
ERROR[D:\a\OpenRCT2\OpenRCT2\src\openrct2\interface\Screenshot.cpp:73 (WriteDpiToFile)]: Unable to write png: PNG ERROR

Steps to reproduce

  1. Open Options.
  2. Select "Software" drawing engine.
  3. Select "Software (Hardware Display)" drawing engine.
  4. Crash.

Surprisingly enough everything works fine if I switch from OpenGL to "Software (Hardware Display)".

Attachments

crash.zip
@Basssiiie Basssiiie added the bug Something went wrong. label Jul 16, 2024
@cheweytoo
Copy link
Contributor

This seems to be OS-specific: I see no crash with the Linux AppImage build, from 3467760 develop.

ZehMatt added a commit to ZehMatt/OpenRCT2 that referenced this issue Aug 9, 2024
@ZehMatt
Fix OpenRCT2#22316: Always recreate the window when changing drawing …
ed30442 
…engine
@ZehMatt ZehMatt mentioned this issue Aug 9, 2024
Merged
janisozaur added a commit that referenced this issue Sep 1, 2024
@janisozaur
Release v0.4.14
18492da 
- Feature: [#15750] Allow using different types of park entrance in one park.
- Feature: [#20942] Allow removing all park fences from the Cheats window.
- Feature: [#21675] Guests ignore price limit cheat.
- Feature: [#22206] Add option to randomise train or vehicle colours.
- Feature: [#22392] [Plugin] Expose ride vehicle’s spin to the plugin API.
- Feature: [#22414] Finance graphs can be resized.
- Feature: [#22569] Footpath placement now respects the construction modifier keys (ctrl/shift).
- Change: [#21189] Patches to fix scenario bugs are now described in .parkpatch files, instead of inside the code.
- Change: [#21659] Increase the Hybrid Roller Coaster’s maximum lift speed to 17 km/h (11 mph).
- Change: [#22466] The Clear Scenery tool now uses a bulldozer cursor instead of a generic crosshair.
- Change: [#22490] The tool to change land and construction rights has been moved out of the Map window.
- Change: [#22490] In sandbox mode, changing land or construction rights now acts as buying or selling.
- Change: [#22491] Scrollbars are now hidden if the scrollable widget is not actually overflowing.
- Change: [#22541] In editor/sandbox mode, tool widgets now appear on the side of the map window, instead of the bottom.
- Change: [#22592] Cheats have been redistributed along three new tabs: date, staff, and nature/weather.
- Fix: [#21123] Transparency options are not respected on startup.
- Fix: [#21189] Additional missing/misplaced land & construction rights tiles in Schneider Shores and Urban Park.
- Fix: [#21908] Errors showing up when placing/moving track design previews.
- Fix: [#22307] Hover tooltips in financial charts are not invalidated properly.
- Fix: [#22316] Potential crash when switching the drawing engine while the game is running.
- Fix: [#22395, #22396] Misaligned tick marks in financial and guest count graphs (original bug).
- Fix: [#22457] Potential crash opening the scenario select window.
- Fix: [#22520] Virtual floor no longer appears when holding modifier keys during track construction.
- Fix: [#22527] Forcing an element type to “wall” via scripts can crash the game.
- Fix: [#22582] Lighting effects are not enabled/disabled correctly, making the game appear frozen.
- Fix: [#22598] Add several .parkpatch files to .sea scenarios with corresponding patches for RCT1 and RCT2 scenarios.
- Fix: [#22606] Virtual floor is sometimes drawn above the path when placing paths.
- Fix: [#22625] Fix compilation with orignal ride ratings.
- Fix: [#22663] Additional missing/misplaced land & construction rights tiles in Mystic Mountain, Build your own Six Flags Holland and Build your own Six Flags over Texas.
- Fix: [#22671] Game default to hide supports on startup.
- Fix: [#22671] Unchecking invisible option does not uncheck see-through option on transparency options and vice versa.
- Fix: [#22677] Hovering the file list in the load/save window causes a slowdown.
Sadret pushed a commit to Sadret/OpenRCT2 that referenced this issue Sep 7, 2024
@ZehMatt @Sadret
Fix OpenRCT2#22316: Always recreate the window when changing drawing …
461249d 
…engine
Sadret pushed a commit to Sadret/OpenRCT2 that referenced this issue Sep 7, 2024
@janisozaur @Sadret
Release v0.4.14
b066ece 
- Feature: [OpenRCT2#15750] Allow using different types of park entrance in one park.
- Feature: [OpenRCT2#20942] Allow removing all park fences from the Cheats window.
- Feature: [OpenRCT2#21675] Guests ignore price limit cheat.
- Feature: [OpenRCT2#22206] Add option to randomise train or vehicle colours.
- Feature: [OpenRCT2#22392] [Plugin] Expose ride vehicle’s spin to the plugin API.
- Feature: [OpenRCT2#22414] Finance graphs can be resized.
- Feature: [OpenRCT2#22569] Footpath placement now respects the construction modifier keys (ctrl/shift).
- Change: [OpenRCT2#21189] Patches to fix scenario bugs are now described in .parkpatch files, instead of inside the code.
- Change: [OpenRCT2#21659] Increase the Hybrid Roller Coaster’s maximum lift speed to 17 km/h (11 mph).
- Change: [OpenRCT2#22466] The Clear Scenery tool now uses a bulldozer cursor instead of a generic crosshair.
- Change: [OpenRCT2#22490] The tool to change land and construction rights has been moved out of the Map window.
- Change: [OpenRCT2#22490] In sandbox mode, changing land or construction rights now acts as buying or selling.
- Change: [OpenRCT2#22491] Scrollbars are now hidden if the scrollable widget is not actually overflowing.
- Change: [OpenRCT2#22541] In editor/sandbox mode, tool widgets now appear on the side of the map window, instead of the bottom.
- Change: [OpenRCT2#22592] Cheats have been redistributed along three new tabs: date, staff, and nature/weather.
- Fix: [OpenRCT2#21123] Transparency options are not respected on startup.
- Fix: [OpenRCT2#21189] Additional missing/misplaced land & construction rights tiles in Schneider Shores and Urban Park.
- Fix: [OpenRCT2#21908] Errors showing up when placing/moving track design previews.
- Fix: [OpenRCT2#22307] Hover tooltips in financial charts are not invalidated properly.
- Fix: [OpenRCT2#22316] Potential crash when switching the drawing engine while the game is running.
- Fix: [OpenRCT2#22395, OpenRCT2#22396] Misaligned tick marks in financial and guest count graphs (original bug).
- Fix: [OpenRCT2#22457] Potential crash opening the scenario select window.
- Fix: [OpenRCT2#22520] Virtual floor no longer appears when holding modifier keys during track construction.
- Fix: [OpenRCT2#22527] Forcing an element type to “wall” via scripts can crash the game.
- Fix: [OpenRCT2#22582] Lighting effects are not enabled/disabled correctly, making the game appear frozen.
- Fix: [OpenRCT2#22598] Add several .parkpatch files to .sea scenarios with corresponding patches for RCT1 and RCT2 scenarios.
- Fix: [OpenRCT2#22606] Virtual floor is sometimes drawn above the path when placing paths.
- Fix: [OpenRCT2#22625] Fix compilation with orignal ride ratings.
- Fix: [OpenRCT2#22663] Additional missing/misplaced land & construction rights tiles in Mystic Mountain, Build your own Six Flags Holland and Build your own Six Flags over Texas.
- Fix: [OpenRCT2#22671] Game default to hide supports on startup.
- Fix: [OpenRCT2#22671] Unchecking invisible option does not uncheck see-through option on transparency options and vice versa.
- Fix: [OpenRCT2#22677] Hovering the file list in the load/save window causes a slowdown.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something went wrong.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #22316: Always recreate the window when changing drawing engine ZehMatt/OpenRCT2
2 participants
@Basssiiie @cheweytoo