Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganise cheats window #22592

Merged
merged 7 commits into from
Aug 19, 2024
Merged

Reorganise cheats window #22592

merged 7 commits into from
Aug 19, 2024

Conversation

AaronVanGeffen
Copy link
Member

@AaronVanGeffen AaronVanGeffen commented Aug 19, 2024 •
edited
Loading

This PR reorganises the cheats window to make it easier to find cheats. To this end, three new tabs are introduced: date, staff, and nature/weather. The other tabs are reworked to account for the moved widgets, as well as to address layout inconsistencies.

Finance tab

Forest Frontiers 2024-08-19 20-50-54

Date tab (split off from Finance)

Forest Frontiers 2024-08-19 20-50-55

Guest tab

cheats_3_guests_final

Staff tab (split off from Park)

Forest Frontiers 2024-08-19 20-50-57

Park tab

Forest Frontiers 2024-08-19 21-22-40

Rides tab

Forest Frontiers 2024-08-19 21-22-41

Nature/weather tab (split off from Park)

Forest Frontiers 2024-08-19 20-51-00

@AaronVanGeffen AaronVanGeffen added the changelog This issue/PR deserves a changelog entry. label Aug 19, 2024
@Gymnasiast Gymnasiast added this to the v0.4.14 milestone Aug 19, 2024
Gymnasiast
Gymnasiast approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@Gymnasiast Gymnasiast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all right. The only thing I noticed is that "ignore research" is still on the "Ride cheats" tab, even though it is not limited to those (it works for scenery too). I’ll leave it to you to decide if you want to move that one too.

@AaronVanGeffen
Copy link
Member Author

The only thing I noticed is that "ignore research" is still on the "Ride cheats" tab, even though it is not limited to those (it works for scenery too). I’ll leave it to you to decide if you want to move that one too.

That's a good observation. I honestly didn't know the cheat also affected scenery. However, I think it might not be a good fit for a groupbox called 'Construction'. In that sense, 'Ride/track availability' is the better fit of the two, I think. As such, I prefer to leave it, at least for now.

@AaronVanGeffen AaronVanGeffen merged commit 6278732 into OpenRCT2:develop Aug 19, 2024
22 checks passed
@AaronVanGeffen AaronVanGeffen deleted the cheats-window branch August 19, 2024 21:33
@AaronVanGeffen AaronVanGeffen mentioned this pull request Aug 19, 2024
Open
23 tasks
janisozaur added a commit that referenced this pull request Sep 1, 2024
@janisozaur
Release v0.4.14
18492da 
- Feature: [#15750] Allow using different types of park entrance in one park.
- Feature: [#20942] Allow removing all park fences from the Cheats window.
- Feature: [#21675] Guests ignore price limit cheat.
- Feature: [#22206] Add option to randomise train or vehicle colours.
- Feature: [#22392] [Plugin] Expose ride vehicle’s spin to the plugin API.
- Feature: [#22414] Finance graphs can be resized.
- Feature: [#22569] Footpath placement now respects the construction modifier keys (ctrl/shift).
- Change: [#21189] Patches to fix scenario bugs are now described in .parkpatch files, instead of inside the code.
- Change: [#21659] Increase the Hybrid Roller Coaster’s maximum lift speed to 17 km/h (11 mph).
- Change: [#22466] The Clear Scenery tool now uses a bulldozer cursor instead of a generic crosshair.
- Change: [#22490] The tool to change land and construction rights has been moved out of the Map window.
- Change: [#22490] In sandbox mode, changing land or construction rights now acts as buying or selling.
- Change: [#22491] Scrollbars are now hidden if the scrollable widget is not actually overflowing.
- Change: [#22541] In editor/sandbox mode, tool widgets now appear on the side of the map window, instead of the bottom.
- Change: [#22592] Cheats have been redistributed along three new tabs: date, staff, and nature/weather.
- Fix: [#21123] Transparency options are not respected on startup.
- Fix: [#21189] Additional missing/misplaced land & construction rights tiles in Schneider Shores and Urban Park.
- Fix: [#21908] Errors showing up when placing/moving track design previews.
- Fix: [#22307] Hover tooltips in financial charts are not invalidated properly.
- Fix: [#22316] Potential crash when switching the drawing engine while the game is running.
- Fix: [#22395, #22396] Misaligned tick marks in financial and guest count graphs (original bug).
- Fix: [#22457] Potential crash opening the scenario select window.
- Fix: [#22520] Virtual floor no longer appears when holding modifier keys during track construction.
- Fix: [#22527] Forcing an element type to “wall” via scripts can crash the game.
- Fix: [#22582] Lighting effects are not enabled/disabled correctly, making the game appear frozen.
- Fix: [#22598] Add several .parkpatch files to .sea scenarios with corresponding patches for RCT1 and RCT2 scenarios.
- Fix: [#22606] Virtual floor is sometimes drawn above the path when placing paths.
- Fix: [#22625] Fix compilation with orignal ride ratings.
- Fix: [#22663] Additional missing/misplaced land & construction rights tiles in Mystic Mountain, Build your own Six Flags Holland and Build your own Six Flags over Texas.
- Fix: [#22671] Game default to hide supports on startup.
- Fix: [#22671] Unchecking invisible option does not uncheck see-through option on transparency options and vice versa.
- Fix: [#22677] Hovering the file list in the load/save window causes a slowdown.
Sadret pushed a commit to Sadret/OpenRCT2 that referenced this pull request Sep 7, 2024
@janisozaur @Sadret
Release v0.4.14
b066ece 
- Feature: [OpenRCT2#15750] Allow using different types of park entrance in one park.
- Feature: [OpenRCT2#20942] Allow removing all park fences from the Cheats window.
- Feature: [OpenRCT2#21675] Guests ignore price limit cheat.
- Feature: [OpenRCT2#22206] Add option to randomise train or vehicle colours.
- Feature: [OpenRCT2#22392] [Plugin] Expose ride vehicle’s spin to the plugin API.
- Feature: [OpenRCT2#22414] Finance graphs can be resized.
- Feature: [OpenRCT2#22569] Footpath placement now respects the construction modifier keys (ctrl/shift).
- Change: [OpenRCT2#21189] Patches to fix scenario bugs are now described in .parkpatch files, instead of inside the code.
- Change: [OpenRCT2#21659] Increase the Hybrid Roller Coaster’s maximum lift speed to 17 km/h (11 mph).
- Change: [OpenRCT2#22466] The Clear Scenery tool now uses a bulldozer cursor instead of a generic crosshair.
- Change: [OpenRCT2#22490] The tool to change land and construction rights has been moved out of the Map window.
- Change: [OpenRCT2#22490] In sandbox mode, changing land or construction rights now acts as buying or selling.
- Change: [OpenRCT2#22491] Scrollbars are now hidden if the scrollable widget is not actually overflowing.
- Change: [OpenRCT2#22541] In editor/sandbox mode, tool widgets now appear on the side of the map window, instead of the bottom.
- Change: [OpenRCT2#22592] Cheats have been redistributed along three new tabs: date, staff, and nature/weather.
- Fix: [OpenRCT2#21123] Transparency options are not respected on startup.
- Fix: [OpenRCT2#21189] Additional missing/misplaced land & construction rights tiles in Schneider Shores and Urban Park.
- Fix: [OpenRCT2#21908] Errors showing up when placing/moving track design previews.
- Fix: [OpenRCT2#22307] Hover tooltips in financial charts are not invalidated properly.
- Fix: [OpenRCT2#22316] Potential crash when switching the drawing engine while the game is running.
- Fix: [OpenRCT2#22395, OpenRCT2#22396] Misaligned tick marks in financial and guest count graphs (original bug).
- Fix: [OpenRCT2#22457] Potential crash opening the scenario select window.
- Fix: [OpenRCT2#22520] Virtual floor no longer appears when holding modifier keys during track construction.
- Fix: [OpenRCT2#22527] Forcing an element type to “wall” via scripts can crash the game.
- Fix: [OpenRCT2#22582] Lighting effects are not enabled/disabled correctly, making the game appear frozen.
- Fix: [OpenRCT2#22598] Add several .parkpatch files to .sea scenarios with corresponding patches for RCT1 and RCT2 scenarios.
- Fix: [OpenRCT2#22606] Virtual floor is sometimes drawn above the path when placing paths.
- Fix: [OpenRCT2#22625] Fix compilation with orignal ride ratings.
- Fix: [OpenRCT2#22663] Additional missing/misplaced land & construction rights tiles in Mystic Mountain, Build your own Six Flags Holland and Build your own Six Flags over Texas.
- Fix: [OpenRCT2#22671] Game default to hide supports on startup.
- Fix: [OpenRCT2#22671] Unchecking invisible option does not uncheck see-through option on transparency options and vice versa.
- Fix: [OpenRCT2#22677] Hovering the file list in the load/save window causes a slowdown.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gymnasiast Gymnasiast Gymnasiast approved these changes

Assignees
No one assigned
Labels
changelog This issue/PR deserves a changelog entry.
Projects
None yet
Milestone
v0.4.14
Development

Successfully merging this pull request may close these issues.
2 participants
@AaronVanGeffen @Gymnasiast