Improve financial and park history graphs

[mrmbernardi]

This PR fixes #22396, #22395, #22307, and #11285.

I should also be able to make the following improvements:

• Make the graphs resizeable
• Improve the readability of the hover tooltip
• Make the guest count graph display numbers above 5,000
• Improve the algorithm that determines the Y axis labels

I originally wanted to bring the hover tooltips to the park rating and guests in park graphs. However, the values are compressed down to 8 bits and it would require modifying the save format to change this. Since the values aren't even accurate anyway, I also figured there would be no point bringing the resize feature to these graphs either.

This makes STR_GRAPH_AXIS_LABEL and STR_FINANCES_FINANCIAL_GRAPH_CASH_VALUE obsolete in the string tables.

Things to consider in the future which are now easier with the new code:

• Allowing the user to change the amount of plotted points
• Bringing resizeability and tooltips to the park graphs

[mrmbernardi]

If the review is too big for the milestone, feel free to push it back to after the next version.

Also please advise on the changelog line as this fixes a few things.

[AaronVanGeffen]

Also please advise on the changelog line as this fixes a few things.

Just because it's one PR doesn't mean you need to put everything on one line. If it addresses multiple distinct issues, please use separate changelog entries as well :)

I'd like to suggest something among the lines of:

- Fix: [#22307] Scan lines in financial charts are not invalidated properly.
- Fix: [#22395, #22396] Misaligned tick marks in financial and guest count graphs.

[AaronVanGeffen]

This is working very nicely! Vastly improved chart performance, much cleaner code, and I like how the finance window charts are now resizeable.

I wonder if it's worth making the charts in the park window resizeable and 'scanable' as well. Something for a follow-up PR though, perhaps :)

[mrmbernardi]

I added a new y axis label algorithm. It simply increments the leading digit of the max and sets all other digits to zero. E.g. if the maximum value in the plot is 6810, then the graph will be plotted from 0 to 7000 (for a non-centred graph).

[ZehMatt]

I think there are a couple of open issues which can probably closed now, also good work.

[ZehMatt]

There are unfortunately some issues.

[J-PIE-314]

Yes, also notice that the negative numbers are above the positive numbers.

[mrmbernardi]

Sorted in #22488

[cheweytoo]

This has literal overflow issues ;-)

As seen in 9f0125b develop:

Also, I note a distinct lack of graph.

[mrmbernardi]

This has literal overflow issues ;-)

As seen in 9f0125b develop:

Also, I note a distinct lack of graph.

Send me the save and I'll fix it ;)

[cheweytoo]

Here it is:

overflowing_millions.zip

[mrmbernardi]

@cheweytoo

Should be fixed in #22498.

I always knew this was possible, but I didn't think people would typically have so much money. The graph will still glitch out if you get a few orders of magnitude away from the integer maximum for the money count, but you would need hundreds of trillions of euros or something thereabouts.

The guest graph will also overflow if you have 100,000 guests or more, but I don't think this is likely. I thought the practical guest limit was around 10k, but you seem to have 20k in your park, at least before you deleted the entire park for some reason.

[cheweytoo]

@cheweytoo

Should be fixed in #22498.

Thanks!

I thought the practical guest limit was around 10k, but you seem to have 20k in your park

It's stable at about 17.5k thanks to permanent advertising, many ATMs, and lots of entertainers. I should really start a new, larger long-term park now that the various limits are higher – if only to see if a higher soft guest cap would allow to increase this even further.

at least before you deleted the entire park for some reason.

I usually try to deliver as minimal a test case as possible. Might have gone a bit overboard this time, but using the large scale deletion tools with reckless abandon can be fun too. ;-)