This repository has been archived by the owner on Mar 28, 2024. It is now read-only.
Add module spp_programs_sp for managing service points in entitlements #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
gonzalesedwin1123
commented
Aug 29, 2023
•
gonzalesedwin1123
commented
- Default Entitlement Manager
- Cash Entitlement Manager
- In-kind Entitlement Manager
Codecov Report
@@ Coverage Diff @@
## 15.1.1 #110 +/- ##
==========================================
- Coverage 80.26% 75.47% -4.80%
==========================================
Files 75 85 +10
Lines 1718 1900 +182
Branches 185 223 +38
==========================================
+ Hits 1379 1434 +55
- Misses 287 414 +127
Partials 52 52
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…ride of create_g2p_program function
github-actions
bot
requested review from
emjay0921,
jeremi,
nhatnm0612 and
reichie020212
reichie020212
approved these changes
Oct 19, 2023
Comment on lines
18
to
30
| def create_g2p_program(self): | ||
| # Create a new journal for this program | ||
| journal_id = self.create_journal(self.name, self.currency_id.id) | ||
|
|
||
| return self.env["g2p.program"].create( | ||
| { | ||
| "name": self.name, | ||
| "journal_id": journal_id, | ||
| "target_type": self.target_type, | ||
| # Add the store_sp_in_entitlements field in program module | ||
| "store_sp_in_entitlements": self.store_sp_in_entitlements, | ||
| } | ||
| ) |
There was a problem hiding this comment.
@gonzalesedwin1123 I suggest to override using super instead of overwrite. check below sample
def create_g2p_program(self):
program_id = super().create_g2p_program()
program_id. store_sp_in_entitlements = self. store_sp_in_entitlements
return program_id
There was a problem hiding this comment.
@gonzalesedwin1123 I updated the parent code of create_g2p_program and changed it to get_program_vals
you can now change it to this
def get_program_vals(self):
vals = super().get_program_vals()
vals.update({
"store_sp_in_entitlements": self.store_sp_in_entitlements,
})
return vals
emjay0921
approved these changes
Oct 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.