Fix module removal task handling #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the module removal task handling where the code was incorrectly returning a nested Task instead of a completed Task directly.
- Corrected the return value in the module removal lambda to return
Task.CompletedTaskinstead ofTask.FromResult(Task.CompletedTask)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| _logger.LogInformation("Removing module {ModuleId}", moduleTask.Key); | ||
| RemoveModule(moduleTask.Key); | ||
| return Task.FromResult(Task.CompletedTask); | ||
| return Task.CompletedTask; |
There was a problem hiding this comment.
The fix correctly addresses the nested Task issue, but this appears to be inside an async lambda (line 100 shows 'async install =>'). Since this is an async lambda returning Task.CompletedTask synchronously while the other branch (install) uses 'await', this creates an inconsistency. Consider whether this lambda should be async or if the install branch should be refactored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68f794441f288327844ae0a8e2ee9ee7