Skip to content

Fix module removal task handling #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LucHeart merged 1 commit into from
Oct 21, 2025
Merged

Fix module removal task handling #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Desktop/ModuleManager/ModuleManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ await moduleTask.Value.Match(async install =>
{
_logger.LogInformation("Removing module {ModuleId}", moduleTask.Key);
RemoveModule(moduleTask.Key);
return Task.FromResult(Task.CompletedTask);
return Task.CompletedTask;
Copy link

Copilot AI Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix correctly addresses the nested Task issue, but this appears to be inside an async lambda (line 100 shows 'async install =>'). Since this is an async lambda returning Task.CompletedTask synchronously while the other branch (install) uses 'await', this creates an inconsistency. Consider whether this lambda should be async or if the install branch should be refactored.

Copilot uses AI. Check for mistakes.
});
}

Expand Down