Skip to content

Conversation

@LucHeart
Copy link
Member

Summary

  • ensure module component activation skips already-set properties without aborting the rest of the injections

Testing

  • not run (dotnet SDK not available in container)

https://chatgpt.com/codex/tasks/task_e_68fa1fd236448327bbcc61ed18e99b58

Copilot AI review requested due to automatic review settings October 23, 2025 12:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug in the module dependency injection logic where encountering a property that's already been set would cause the injection process to abort prematurely, preventing subsequent properties from being injected.

Key Changes:

  • Changed early return to continue statement in property injection loop to ensure all properties are processed

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

"Property {PropertyName} on component {ComponentType} has already been set, skipping injection",
prop.Name, componentType.Name);
return;
continue;
Copy link

Copilot AI Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change from return to continue correctly fixes the logic to process all properties in the injection loop. However, verify that the loop iterating over properties properly handles any exceptions that might be thrown during individual property injections, to ensure one failing property doesn't prevent others from being injected.

Copilot uses AI. Check for mistakes.
@LucHeart LucHeart merged commit c1f8518 into develop Oct 23, 2025
13 checks passed
@LucHeart LucHeart deleted the codex/find-and-fix-a-bug branch October 23, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants