Skip to content

Fix module injection to continue processing remaining properties #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LucHeart merged 1 commit into from
Oct 23, 2025
Merged

Fix module injection to continue processing remaining properties #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Desktop/OpenShockModuleComponentActivator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ private void InjectModuleDependencies(object instance, Type componentType, Loade
_logger.LogWarning(
"Property {PropertyName} on component {ComponentType} has already been set, skipping injection",
prop.Name, componentType.Name);
return;
continue;
Copy link

Copilot AI Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change from return to continue correctly fixes the logic to process all properties in the injection loop. However, verify that the loop iterating over properties properly handles any exceptions that might be thrown during individual property injections, to ensure one failing property doesn't prevent others from being injected.

Copilot uses AI. Check for mistakes.
}

var service = module.Module.ModuleServiceProvider.GetService(prop.PropertyType);
Expand Down