Add version gating for Zmq and Qt deprecations #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #470 +/- ##
========================================
Coverage 48.12% 48.13%
========================================
Files 128 128
Lines 9934 9933 -1
========================================
Hits 4781 4781
+ Misses 5153 5152 -1
Continue to review full report at Codecov.
|
|
Oh, hey, Travis finally woke up. Neat. |
|
Merging this, as these are both small, future-proofing changes to the code. |
This was
linked to
issues
Mar 23, 2020
This was referenced Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves both of the deprecations showing up in the codebase when building with current dependency versions.
QImage::sizeInBytes()is deprecatedstarting with Qt 5.10. (Correction:QImage::byteCount()is deprecated,QImage::sizeInBytes()is its replacement.)send()form we've been using starting with version 4.3.1.The replacement ZMQ API includes a second
flagsargument. We take advantage of the new field to specifyzmq::send_flags::dontwait, flagging the message for immediate delivery. (It's possible we could usedontwaitin older ZMQ versions, so perhaps the version check could be broadened. It's also possible thatdontwaithas a negative performance impact, in which case it might be better to remove it. Unit tests would be helpful, but they do not yet exist.)