-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update release log formatting #486
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #486 +/- ##
========================================
Coverage 48.24% 48.24%
========================================
Files 128 128
Lines 9962 9962
========================================
Hits 4806 4806
Misses 5156 5156 Continue to review full report at Codecov.
|
@ferdnyc These log files are parsed in openshot-qt, on our About dialog. They are copied into openshot-qt on the
And then we parse them on
Just wanted to make sure that if we change the git log format (which I like by the way), that it will not break our About dialog. And if it does break, perhaps we can just patch the parsing logic in Needed things...
|
Codecov Report
@@ Coverage Diff @@
## develop #486 +/- ##
========================================
Coverage 48.77% 48.77%
========================================
Files 129 129
Lines 10036 10036
========================================
Hits 4895 4895
Misses 5141 5141 Continue to review full report at Codecov.
|
Ohhh! That, I did not realize, thanks.
Yeah, agreed. I wasn't aware of the extra dependency there. It'll definitely need more testing and cleanup. To WIP it goes, for now! |
This is no longer WIP, though it does now depend on OpenShot/openshot-qt#3653 getting merged first. |
LGTM! Thanks! I love the markdown support! |
Like OpenShot/libopenshot-audio#92, this makes some tweaks to the
git
commands that the builders use to generate theinstall*/share/repo.log
file during each build stage, to make the contents maximally conducive to cut-and-paste insertion directly into a GitHub Release description.From the libopenshot-audio PR:
Here's an example run listing the changes since
v0.2.5
:And if I cut-and-paste that output here, unmodified: