About dialog: Enhance changelog parsing, add support for new format #3653
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I finally came up with the perfect solution to OpenShot/libopenshot#486 and OpenShot/libopenshot-audio#92 (my proposed new Git changelog formats), which have been in WIP status pending compatibility with the About dialog's changelog listing.
This PR updates
about.py
to:parse_changelog()
, called once per projectparse_new_changelog()
to read the new-format filessettings/project.log
, the new files inresources/project.log
.If it finds a new-style file, it'll read it. If it can't, or it's not found, it'll try for an old-style file. If neither can be found/read, it'll remove that individual tab from the dialog, so that there aren't any empty listings. (If none of the 6 files is present, the Changelog button is removed from the About dialog completely, same as always.)
That means that this can (and should) be merged before any format changes. It'll keep on supporting the old format, and then at whatever point we choose we can switch over to generating new format files and placing them in
resources/
instead.