Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AppImage: Fix a crash issue running on systems with newer OpenSSL #3283

Merged
merged 1 commit into from
Mar 17, 2020
Merged

AppImage: Fix a crash issue running on systems with newer OpenSSL #3283

merged 1 commit into from
Mar 17, 2020

Conversation

ferdnyc
Copy link
Contributor

@ferdnyc ferdnyc commented Mar 8, 2020

On systems with newer versions of openssl, the installed file /etc/ssl/openssl.cnf is incompatible with our bundled version of libssl.so. But it will be loaded by default, leading to a crash, unless OPENSSL_CONF is set to /dev/null (or some other invalid path) in the AppImage environment.

Fixes #3242

@ferdnyc
AppImage: Set OPENSSL_CONF for newer openssl compat
37edb50 
On systems with newer versions of openssl, the installed file
/etc/ssl/openssl.cnf is incompatible with our bundled version of
libssl.so, but will be loaded by default unless OPENSSL_CONF is
set to /dev/null (or some other invalid path) in the environment.
@ferdnyc ferdnyc added closer This PR fixes one or more reported Issues OS:Linux Issues specific to the Linux operating system labels Mar 8, 2020
@ferdnyc ferdnyc mentioned this pull request Mar 9, 2020
Closed
@ferdnyc
Copy link
Contributor Author

ferdnyc commented Mar 17, 2020

Merging in the hopes of un-failing AppImages on Debian 11 installs.

@ferdnyc ferdnyc merged commit d7cc86c into OpenShot:develop Mar 17, 2020
@ferdnyc ferdnyc deleted the appimage-launcher branch March 17, 2020 21:27
@cometchaserde
Copy link

Hi,
I tried OpenShot-v2.5.1-dev2-1584614053-2c6d25ee-232f3f79-x86_64.AppImage
with Debian 10.3.
It doesn't work. Only with the workaround -> export OPENSSL_CONF=/dev/null

@ferdnyc
Copy link
Contributor Author

ferdnyc commented Mar 20, 2020

@cometchaserde Thanks, I'll look into it. Maybe I missed something. (Or maybe that has to be set before the AppImage launches, in which case we might have to try another workaround.)

@ferdnyc
Copy link
Contributor Author

ferdnyc commented Mar 20, 2020

As soon as Travis passes #3304 I'll merge it and get a new image built, so I can check whether that was the problem.

@ferdnyc
Copy link
Contributor Author

ferdnyc commented Mar 20, 2020

OK, that didn't work either. Turns out, the launch environment is compiled into the launcher itself, so I had to build a new binary to include in the AppImage. That's just been merged as #3305, and new Daily Builds should be ready in just a few minutes.

@ferdnyc
Copy link
Contributor Author

ferdnyc commented Mar 20, 2020

Still waiting on the Mac builder which tends to take a little longer, but I can tell you that the AppImage build was successful and when it appears, it'll have this filename:

OpenShot-v2.5.1-dev2-1584747682-2c6d25ee-232f3f79-x86_64.AppImage

@cometchaserde
Copy link

Hi,
I tried it with the build you mentioned. It works. Great. :-)

@ferdnyc
Copy link
Contributor Author

ferdnyc commented Mar 22, 2020

Great, thanks @cometchaserde!

@ferdnyc ferdnyc mentioned this pull request Apr 1, 2020
Closed
@ferdnyc ferdnyc mentioned this pull request Nov 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
closer This PR fixes one or more reported Issues OS:Linux Issues specific to the Linux operating system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot open project file created with Openshot 2.4.4 on Debian 10
2 participants
@ferdnyc @cometchaserde