Moving Collectors to 'available' so they are not enabled by default

[johann8384]

Closes #190

[johann8384]

@tsuna @vasiliyk I'd prefer one of you weigh in on these rather than merge my own PR.

[tsuna]

So is the expectation that distributions will package all these collectors using the available directory and that after installation, the system operators will symlink them into the 0 directory to enable the collectors of their choice (perhaps with Puppet or Chef or whatever, or manually)?

[johann8384]

Yes, I think I'll modify it to be a little different, like maybe have an "available", an "osx", a "freebsd" and try to put the current collectors in available and then the os specific ones in the other two folders.

I'm not 100% sure how this one will work out yet, and I need to properly coordinate it with the packaging so that it works.

I'm planning to build a build pipeline that will use Docker to build for RPM and DEB packages. I suspect I can integrate the Arista EOS build into that also.

[johann8384]

That is the best I layout I have seen so far, but I feel like there is a better way still.

[johann8384]

What about collectors that work on OSX and Linux, but not FreeBSD? (or some such thing)

Edit: Or more likely, base system collectors that work more globally

[johann8384]

I guess the packaging/install script could enable a set of collectors by default based on the OS. Or, we could have:

collectors-available/
┗ global/
  ┗ long-lived/
  ┗ one-shot/
┗ linux/
  ┗ long-lived/
  ┗ one-shot/
┗ freebsd/
  ┗ long-lived/
  ┗ one-shot/
┗ osx/
  ┗ long-lived/
  ┗ one-shot/
┗ softwares/
  ┗ long-lived/
  ┗ one-shot/
collectors-enabled/
┗ 0/
┗ 60/
┗ 3600/
┗ (...)
collectors-etc/

This would leave the collectors that work everywhere in global. We could also encourage collectors to make use of a "get_tcollector_platform()" function in utils that would essentially wrap platform.system().

This way a collector that could do most things on Linux and FreeBSD could politely decline to run on OSX, or if the available metrics were different, on each platform output what it could.

[vasiliyk]

@johann8384 , thank you for putting it all together!!

I like the proposed structure and idea to enable global + OS specific collectors in packaging/install script.
What help do you need to finalize PR?

[vasiliyk]

implemented and merged with the commit 881e215

Documentation updated to reflect the change: http://opentsdb.net/docs/build/html/user_guide/utilities/tcollector.html