Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support collect Hadoop that turning on https #459

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: support collect Hadoop that turning on https #459

wants to merge 1 commit into from

Conversation

ZhaoQi99
Copy link

Close #458

@vasiliyk
Copy link
Member

vasiliyk commented Apr 26, 2024 •
edited
Loading

Thank you for contributing!

Should we have a configuration file in collectors/etc folder with variables like:

COLLECTION_INTERVAL = 15  # seconds
TARGET_HOST = "localhost"
TARGET_PORT = 50075
TARGET_HTTPS_PORT = 50475

@ZhaoQi99
Copy link
Author

Thank you for contributing!

Should we have a configuration file in collectors/etc folder with variables like:

COLLECTION_INTERVAL = 15  # seconds
TARGET_HOST = "localhost"
TARGET_PORT = 50075
TARGET_HTTPS_PORT = 50475

Yep, I also think so. But there are currently many components (not just Hadoop) here that do not have configuration files. Should we open another PR to do this？

@vasiliyk
Copy link
Member

vasiliyk commented Apr 28, 2024 •
edited
Loading

You can just add another commit to this PR with a config usage.
I will try to create configs where we do not have them before migrating to new directory structure as per #239

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support collect data points for Hadoop that turning on HTTPS
2 participants
@ZhaoQi99 @vasiliyk