Convert HTML tables to Markdown #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AdrienFines could you please double-check the impact on the last two services? 🙂 I already checked MouthShut's Privacy Policy, no change. |
|
I checked each service and everything seems fine. There is only one little flaw : when no column headers are found, one empty line is added at the beginning of the table (for example in StackOverflow Privacy Policy). Yet I don't think it will be that annoying. |
Yup, saw that too. It is a workaround added in mixmark-io/turndown-plugin-gfm#10. Thanks for the review! 😃 |
Convert HTML tables and strikethrough
Official plugin is not maintained, the joplin-turndown-plugin-gfm fork contains fixes for HTML tables conversions See mixmark-io/turndown-plugin-gfm#3
Ndpnt
force-pushed
the
turndown-extension
branch
from
5852bb9 to
0c97f5b
Compare
Ndpnt
approved these changes
Jul 29, 2020
martinratinaud
pushed a commit
that referenced
this pull request
Aug 6, 2021
Convert HTML tables to Markdown
martinratinaud
pushed a commit
that referenced
this pull request
Aug 6, 2021
Convert HTML tables to Markdown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following services contain at least one
<table>. They have a checkbox associated with them that should be checked when the result of running the filters on them has been double-checked.