Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*passport-aol* failing #1369

Closed
Martii opened this issue May 21, 2018 · 8 comments
Closed

*passport-aol* failing #1369

Martii opened this issue May 21, 2018 · 8 comments
Labels
DB Pertains inclusively to the Database operations.

Comments

@Martii
Copy link
Member

Martii commented May 21, 2018

InternalOpenIDError: Failed to discover OP endpoint URL  (message: No providers found for the given identifier)
    at ~/repo/git/OpenUserJS.org/martii/OpenUserJS.org/node_modules/passport-openid/lib/passport-openid/strategy.js:249:52
    at ~/repo/git/OpenUserJS.org/martii/OpenUserJS.org/node_modules/passport-openid/node_modules/openid/openid.js:787:14
    at ~/repo/git/OpenUserJS.org/martii/OpenUserJS.org/node_modules/passport-openid/node_modules/openid/openid.js:577:13
    at ~/repo/git/OpenUserJS.org/martii/OpenUserJS.org/node_modules/passport-openid/node_modules/openid/openid.js:533:11
    at Request._callback (~/repo/git/OpenUserJS.org/martii/OpenUserJS.org/node_modules/passport-openid/node_modules/openid/openid.js:228:7)
    at Request.self.callback (~/repo/git/OpenUserJS.org/martii/OpenUserJS.org/node_modules/request/request.js:185:22)
    at emitTwo (events.js:126:13)
    at Request.emit (events.js:214:7)
    at Request.<anonymous> (~/repo/git/OpenUserJS.org/martii/OpenUserJS.org/node_modules/request/request.js:1157:10)
    at emitOne (events.js:116:13)
    at Request.emit (events.js:211:7)
    at IncomingMessage.<anonymous> (~/repo/git/OpenUserJS.org/martii/OpenUserJS.org/node_modules/request/request.js:1079:12)
    at Object.onceWrapper (events.js:313:30)
    at emitNone (events.js:111:20)
    at IncomingMessage.emit (events.js:208:7)
    at endReadableNT (_stream_readable.js:1064:12)

Finally dug up my credentials for AOHell.... so anyhow. Dev and production return similar results.

Tried:

Nothing appears to work. I will attempt to dive into the source however OpenID based passports are usually highly unmaintained. I have observed passport-yahoo successfullly auth'ing however I would be willing to consider deprecating OpenID at some point if there aren't any responses from these packages. This includes passport-steam since they are OpenID as well.

@Martii Martii added the tracking upstream Waiting, watching, wanting. label May 21, 2018
@Martii
Copy link
Member Author

Martii commented May 21, 2018

Ref:

Forbidden
You don't have permission to access /auth/openid/xrds on this server.
https://api.screenname.aol.com/auth/openid/xrds

GET /auth/openid/xrds HTTP/1.1
Host: api.screenname.aol.com
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 SeaMonkey/2.49.3
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8
Accept-Language: en-US,en;q=0.5
Accept-Encoding: gzip, deflate, br
DNT: 1
Connection: keep-alive
Upgrade-Insecure-Requests: 1

HTTP/1.1 403 Forbidden
Date: Mon, 21 May 2018 22:11:44 GMT
Server: ATS
Content-Length: 218
Content-Type: text/html; charset=iso-8859-1
Age: 0
Connection: close
Strict-Transport-Security: max-age=15552000

Possible relevant external site at https://stackoverflow.com/questions/7529013/aol-openid-website-verification

Testing corresponding url in passport-yahoo and passport-steam it returns a XML document.

@Martii
Copy link
Member Author

Martii commented May 21, 2018

Ref:

Re: /jaredhanson/passport-aol/tree/05a6346/examples/signon after tweaking to newer express settings

  1. http://localhost:3000
  2. Logging in at http://localhost:3000/login
  3. Browser error of:
InternalOpenIDError: Failed to discover OP endpoint URL
    at ~/tmp/passport-aol/examples/signon/node_modules/passport-openid/lib/passport-openid/strategy.js:249:52
    at ~/tmp/passport-aol/examples/signon/node_modules/openid/openid.js:874:14
    at ~/tmp/passport-aol/examples/signon/node_modules/openid/openid.js:664:13
    at ~/tmp/passport-aol/examples/signon/node_modules/openid/openid.js:620:11
    at done (~/tmp/passport-aol/examples/signon/node_modules/openid/openid.js:258:9)
    at IncomingMessage.<anonymous> (~/tmp/passport-aol/examples/signon/node_modules/openid/openid.js:262:32)
    at emitNone (events.js:111:20)
    at IncomingMessage.emit (events.js:208:7)
    at endReadableNT (_stream_readable.js:1064:12)
    at _combinedTickCallback (internal/process/next_tick.js:138:11)

Same error and url forbidden as last comments.

@Martii
Copy link
Member Author

Martii commented May 21, 2018

Refs:

@Martii
Copy link
Member Author

Martii commented May 21, 2018

So basically in summary providerURL is returning forbidden... that to me indicates either AOL end of lifed OpenID or they have a misconfiguration of their service.

After I look into who is using AOL on OUJS I'm probably going to remove it as an auth altogether... I may even parse the DB and remove AOL auths altogether since not even existing users can get in due to this issue.... UNLESS someone can cite an aol domained document that says otherwise.

Martii added a commit to Martii/OpenUserJS.org that referenced this issue May 22, 2018
NOTES:
* ~18 accounts that have another auth besides AOL
* ~20 accounts that have no visible activity
* ~11 accounts that have visible activity ... however they are orphaned due to dep/aol site failure

Applies to OpenUserJS#1369
Martii added a commit that referenced this issue May 22, 2018
* EOL *passport-aol*

NOTES:
* ~18 accounts that have another auth besides AOL
* ~20 accounts that have no visible activity
* ~11 accounts that have visible activity ... however they are orphaned due to dep/aol site failure

Applies to #1369

* Remove package *passport-aol*

Applies to #1370
@Martii Martii added the DB Pertains inclusively to the Database operations. label May 22, 2018
@Martii Martii self-assigned this May 22, 2018
Martii added a commit to Martii/OpenUserJS.org that referenced this issue May 22, 2018
* Prevents server trip until DB can be cleansed

Applies to OpenUserJS#1369
Martii added a commit that referenced this issue May 22, 2018
* Prevents server trip until DB can be cleansed

Applies to #1369 

Auto-merge
@Martii
Copy link
Member Author

Martii commented May 22, 2018

19 accounts with alternate auths repaired and aol removed.

Pending on what @sizzlemctwizzle says to do with the remainder. May decide if a lot of time passes w/o acknowledgement somewhere.

Martii added a commit to Martii/OpenUserJS.org that referenced this issue May 22, 2018
* Rather than just a 404 page... redirect to login page and denote with QSP when data present
* Some compliance with STYLEGUIDE.md max line length

Applies to OpenUserJS#1369 and OpenUserJS#37
Martii added a commit that referenced this issue May 22, 2018
* Rather than just a 404 page... redirect to login page and denote with QSP when data present
* Some compliance with STYLEGUIDE.md max line length

Applies to #1369 and #37

Auto-merge
@Martii
Copy link
Member Author

Martii commented Jun 17, 2018

Few days back, and today, the url in the passport of url test from /jaredhanson/passport-aol/blob/05a6346/lib/passport-aol/strategy.js#L43 does this now:

HTTP ERROR 404

Problem accessing /auth/openid/xrds. Reason:

    Not Found

Powered by Jetty:// 9.4.z-SNAPSHOT

I think it's safe to presume it's dead and gone. Sure would have been nice if AOL would have made an announcement. This may have been terminated when AIM was.

Anyhow... still haven't decided what to do with those remaining accounts... will probably at least delete the ones that don't have any activity... the rest *still pondering*.

@Martii Martii removed the tracking upstream Waiting, watching, wanting. label Jun 22, 2018
@Martii
Copy link
Member Author

Martii commented Jul 11, 2018

All but 8 orphaned standalone AOL accounts deleted or removed... I'd kind of like to keep the rest of the content around for Copyright validation and Discussion continuity... still pondering...

@Martii
Copy link
Member Author

Martii commented Jul 12, 2018

... ponder complete... should keep them around. They are minimal in quantity and good for a unit test case. Closing.

@Martii Martii closed this as completed Jul 12, 2018
@Martii Martii removed their assignment Sep 23, 2018
@OpenUserJS OpenUserJS locked as resolved and limited conversation to collaborators Apr 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
DB Pertains inclusively to the Database operations.
Development

No branches or pull requests

1 participant