Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graceful failure for invalid auth #1372

Merged
merged 1 commit into from
May 22, 2018
Merged

Graceful failure for invalid auth #1372

merged 1 commit into from
May 22, 2018
+6 −2

Conversation

Martii
Copy link
Member

@Martii Martii commented May 22, 2018

  • Rather than just a 404 page... redirect to login page and denote with QSP when data present
  • Some compliance with STYLEGUIDE.md max line length

Applies to #1369 and #37

@Martii
Graceful failure for invalid auth
4fad917 
* Rather than just a 404 page... redirect to login page and denote with QSP when data present
* Some compliance with STYLEGUIDE.md max line length

Applies to OpenUserJS#1369 and OpenUserJS#37
@Martii Martii added migration Use this to indicate that it may apply to an existing or announced migration. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. labels May 22, 2018
@Martii Martii merged commit 38676d5 into OpenUserJS:master May 22, 2018
@Martii Martii deleted the Issue-1369gracefulFail branch May 22, 2018 02:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. migration Use this to indicate that it may apply to an existing or announced migration.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Martii