-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Google Analytics / Server Side Tracking #339
Comments
👍 on adding Google Analytics It might be also a good idea to share the login credentials for the server, so more people can observe and handle when required. |
Probably does however this is related in part to #330. EDIT: e.g. Should subside when complete (hopefully later this week after the holiday).
Which will be blocked on my nets for sure. GA shares information with their partners which are vast so I'm a -1 at this point without a serious need. The 503's have been present during high traffic periods on the cloud which nodejitsu is responsible for. I'd rather have some additional administration charts (notice the spikes at ~3:50 and ~6:00 whatever coordinated time) exposed and keep everyones privacy intact.
Think cloud here not server.
Not entirely sure what you want from this. Care to elaborate? |
The fact that were getting 503s at all means there's need for it. Server side tracking is definitely needed as not every route is a webpage. And the heaviest load should probably be on the meta pages. 99% of sites use analytics. Us not using it doesn't protect the user at all on those other sites. Users who go out of their way to protect themselves like you won't be affected either. |
The nodejitsu page represents all sites on nodejitsu and is fairly useless for us as we need individual route performance in order to find bottlenecks. |
You are in the vast minority regarding whether a script works or not. It doesn't hurt not having it, and can provide valuable info for when it does work. I am +1. |
You stepped out as an owner of your own free will. Sizzle will determine this for sure since he pays the bills but my vote is in so he can make an educated decision instead of a rash one that is based off of false information about any 503's being present. This isn't a new issue either (and I have maffs to prove it but I'm not at dev machine to upload those) so no one can blame it on the hosting the packages in our project. You are probably incorrect when you said that npm packages are installed soley in our host site. They are probably symlinked in and load balanced across the cloud which would be the smarter thing to do. If anyone can prove that it's worth merit I'd be happy to read it. Until don't make this into a mountain when the other mole hills aren't complete yet. :)
100% of my nets which include many site don't use GA. You are also forgetting that some of the prior PRs are unit tests to probe nodejitsu. You are also forgetting about the revisiting CDNs. I'll be very blunt here and I apologize if someones ego gets bruised in advance the not so bright moment of using cloudflare for hosting when we can't control it or the original maintainers is one of the most inept decisions made. jQuery for example is quite easily referenced on the jQuery domain or at the most google apis. The mightfix is in there because it might be added to the project if sizzle decides so... until then all PRs with it in it will be rejected and you all should probably concentrate on finishing up your other PRs first that you assigned yourselves. I like the one you closed Zren even though it was too much in one shot. Dead code is different than unused library code imo. |
Analytics = some form of reporting. If you think that a large site doesnt have some form of it than you are naive. Just because it's not client side where you can see it doesn't mean its not there. I don't really care about tracking users so much as seeing how many hits were getting, how long the request take, and how many 503s were getting. Larger sites also have the manhour resorces to roll their own tracking analytic software. |
One can say that using GA is naive as well. Assigned to sizzle as he will be in control of it if it gets created on their servers. |
@sizzlemctwizzle |
Yeah, you can take it.
|
* Scoot ga script to script folder * Don't inject/run on dev * Missing semi-colon * Missing IIFE trailing function call invocation... e.g. code with key isn't called * Use strict XHTML syntax for `sync` attribute * Shifted html to the left... mentioned before with @jerone ... most ppl don't use view source anymore and a debugger doesn't need this... plus saves a bit of storage space and transfer size Closes OpenUserJS#339
Post fixes for #339 commits Auto-merge
* Adopt DNT * The "isogram" is basically minified code of what we already had but with mangled identifiers. This is functionally equivalent. Also doesn't reach out to google at all if blocked for anonymous stats that they may collect. Refs: * https://developers.google.com/analytics/devguides/collection/analyticsjs/ * "EU GDPR and California AB 370 provide a legal regime to enforce the respect of this new browser preference." * https://leginfo.legislature.ca.gov/faces/billNavClient.xhtml?bill_id=201320140AB370 * https://www.w3.org/TR/tracking-dnt/ * https://developer.mozilla.org/docs/Web/API/Navigator/doNotTrack * https://github.com/EFForg/dnt-guide Post OpenUserJS#339
* GPDR11 * Adopt DNT * The "isogram" is basically minified code of what we already had but with mangled identifiers. This is functionally equivalent. Also doesn't reach out to google at all if blocked for anonymous stats that they may collect. Refs: * https://developers.google.com/analytics/devguides/collection/analyticsjs/ * "EU GDPR and California AB 370 provide a legal regime to enforce the respect of this new browser preference." * https://leginfo.legislature.ca.gov/faces/billNavClient.xhtml?bill_id=201320140AB370 * https://www.w3.org/TR/tracking-dnt/ * https://developer.mozilla.org/docs/Web/API/Navigator/doNotTrack * https://github.com/EFForg/dnt-guide Post #339 * Put IIFE back to standard Post #1428 Auto-merge
* Per sizzle ca. 2024/01/23 01:59 EST email. Unused by everyone including backend maintainer *(that's me currently and there are other means)* Applies to OpenUserJS#339
* Shouldn't need this anymore as well Applies to OpenUserJS#339
We're getting 503s atm, and it would be good to know how much traffic we're getting to contributes to this. Not sure if @sizzlemctwizzle has server side tracking setup, but we can add something clientside.
Since we're serving static content on the same server, a 503 on a static content request will usually cause the UI to go unstyled.
The text was updated successfully, but these errors were encountered: