Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post fixes for #339 commits #680

Merged
merged 1 commit into from
Jul 29, 2015
Merged

Post fixes for #339 commits #680

merged 1 commit into from
Jul 29, 2015

Conversation

Martii
Copy link
Member

@Martii Martii commented Jul 29, 2015

  • Scoot ga script to script folder
  • Don't inject/run on dev
  • Missing semi-colon
  • Missing IIFE trailing function call invocation... e.g. code with key isn't called
  • Use strict XHTML syntax for sync attribute
  • Shifted html to the left... mentioned before with @jerone ... most ppl don't use view source anymore and a debugger doesn't need this... plus saves a bit of storage space and transfer size

Closes #339

Post fixes for OpenUserJS#339 commits
3c52d87 
* Scoot ga script to script folder
* Don't inject/run on dev
* Missing semi-colon
* Missing IIFE trailing function call invocation... e.g. code with key isn't called
* Use strict XHTML syntax for `sync` attribute
* Shifted html to the left... mentioned before with @jerone ... most ppl don't use view source anymore and a debugger doesn't need this... plus saves a bit of storage space and transfer size

Closes OpenUserJS#339
@Martii Martii added bug You've guessed it... this means a bug is reported. feature Something we don't already have implemented to the best of knowledge but would like to see. labels Jul 29, 2015
Martii added a commit that referenced this pull request Jul 29, 2015
@Martii
Merge pull request #680 from Martii/Issue-339postFix
f75124d 
Post fixes for #339 commits

Auto-merge
@Martii Martii merged commit f75124d into OpenUserJS:master Jul 29, 2015
@Martii Martii deleted the Issue-339postFix branch July 29, 2015 23:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug You've guessed it... this means a bug is reported. feature Something we don't already have implemented to the best of knowledge but would like to see.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Google Analytics / Server Side Tracking
1 participant
@Martii