Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider modifying .../scriptStorage.js in sendMeta to send JSON #718

Closed
Martii opened this issue Aug 26, 2015 · 3 comments · Fixed by #719
Closed

Consider modifying .../scriptStorage.js in sendMeta to send JSON #718

Martii opened this issue Aug 26, 2015 · 3 comments · Fixed by #719
Labels
CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge.

Comments

@Martii
Copy link
Member

Martii commented Aug 26, 2015

As I mentioned here:

If there is time and if possible... I'd like to create another issue ticket with sharing a (specific) JSON of this data

e.g.

May be useful if shared in cooperation with #77 and of course .user.js scripts.

This is relatively simple to do as our meta blocks are already an object so JSON.stringify could be used... does currently show in reverse order but with Objects there is never a guaranteed order as we all should know.

This could be useful for some .user.js as well.
@Martii Martii added enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. labels Aug 26, 2015
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Aug 26, 2015
Alter sendMeta to accept json extension
10cf306 
* One way of OpenUserJS#718

Closes OpenUserJS#718
@Martii Martii self-assigned this Aug 26, 2015
@Martii
Copy link
Member Author

Martii commented Aug 26, 2015

Any reason why we shouldn't do something like this or alternate (preferred) methodology in the code?

@Martii Martii added needs discussion Blah, blah, blah, wahh, wahh, wahh, etc. question A question has been encountered by anyone and has remained unanswered until cleared. labels Aug 26, 2015
@sizzlemctwizzle
Copy link
Member

You have my support on adding the .meta.json route. I'd leave the text version we generate as-is for now. Although trimming it down in the future to @name, @namespace, @version should be a goal.

@Martii
Copy link
Member Author

Martii commented Aug 26, 2015

I'd leave the text version we generate as-is for now.

Giving others migration time is probably a good thing. :)

@Martii Martii mentioned this issue Aug 26, 2015
Merged
@Martii Martii mentioned this issue Aug 29, 2015
Closed
@Martii Martii removed their assignment Aug 29, 2015
@Martii Martii removed needs discussion Blah, blah, blah, wahh, wahh, wahh, etc. question A question has been encountered by anyone and has remained unanswered until cleared. labels Aug 30, 2015
Martii pushed a commit to Martii/UserScripts that referenced this issue Sep 8, 2015
oujs - Meta View 4.0.0.0
758e34d 
* Start using the meta.json route implemented in OpenUserJS/OpenUserJS.org#718
* Drop preference to restore Unit Test nature instead of POC
* Remove usage of external dependencies to resume older browser testing
* Few labeling UI changes
* Trap possible JSON xhr error
* Title space added

**NOTE**:
* JSON parsed Object may be in reverse order... as we all should know Object order is never guaranteed... Arrays however should be in FIFO order always.
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue May 29, 2016
Insert some counts for .meta.json
9c49b6e 
Post followup for OpenUserJS#718 and OpenUserJS#285
@Martii Martii mentioned this issue May 23, 2018
Closed
@OpenUserJS OpenUserJS locked as resolved and limited conversation to collaborators Apr 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Alter sendMeta to accept json extension Martii/OpenUserJS.org
2 participants
@sizzlemctwizzle @Martii